[NET] endianness noise: INADDR_ANY

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

8 files changed, 16 insertions, 15 deletions

diff --git a/arch/sparc/kernel/sys_sunos.c b/arch/sparc/kernel/sys_sunos.c
index 28c187c5d9fd..f5b608bbe8af 100644
--- a/arch/sparc/kernel/sys_sunos.c
+++ b/arch/sparc/kernel/sys_sunos.c
@@ -659,7 +659,7 @@ sunos_nfs_get_server_fd (int fd, struct sockaddr_in *addr)
 
         socket = SOCKET_I(inode);
         local.sin_family = AF_INET;
-        local.sin_addr.s_addr = INADDR_ANY;
+        local.sin_addr.s_addr = htonl(INADDR_ANY);
 
         /* IPPORT_RESERVED = 1024, can't find the definition in the kernel */
         try_port = 1024;
diff --git a/arch/sparc64/kernel/sys_sunos32.c b/arch/sparc64/kernel/sys_sunos32.c
index cfc22d3fe54c..e91194fe39d7 100644
--- a/arch/sparc64/kernel/sys_sunos32.c
+++ b/arch/sparc64/kernel/sys_sunos32.c
@@ -618,7 +618,7 @@ sunos_nfs_get_server_fd (int fd, struct sockaddr_in *addr)
 
         socket = SOCKET_I(inode);
         local.sin_family = AF_INET;
-        local.sin_addr.s_addr = INADDR_ANY;
+        local.sin_addr.s_addr = htonl(INADDR_ANY);
 
         /* IPPORT_RESERVED = 1024, can't find the definition in the kernel */
         try_port = 1024;
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 1fb381843650..bdcf6d3ef62f 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -632,7 +632,7 @@ static int nfs_verify_server_address(struct sockaddr *addr)
         switch (addr->sa_family) {
         case AF_INET: {
                 struct sockaddr_in *sa = (struct sockaddr_in *)addr;
-                return sa->sin_addr.s_addr != INADDR_ANY;
+                return sa->sin_addr.s_addr != htonl(INADDR_ANY);
         }
         case AF_INET6: {
                 struct in6_addr *sa = &((struct sockaddr_in6 *)addr)->sin6_addr;
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 09ca5293d08f..0d109504ed86 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -458,7 +458,7 @@ int inet_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
         err = -EADDRNOTAVAIL;
         if (!sysctl_ip_nonlocal_bind &&
             !inet->freebind &&
-            addr->sin_addr.s_addr != INADDR_ANY &&
+            addr->sin_addr.s_addr != htonl(INADDR_ANY) &&
             chk_addr_ret != RTN_LOCAL &&
             chk_addr_ret != RTN_MULTICAST &&
             chk_addr_ret != RTN_BROADCAST)
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index de0572c88859..f72457b4b0a7 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -583,7 +583,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
                 }
 
                 if (!mreq.imr_ifindex) {
-                        if (mreq.imr_address.s_addr == INADDR_ANY) {
+                        if (mreq.imr_address.s_addr == htonl(INADDR_ANY)) {
                                 inet->mc_index = 0;
                                 inet->mc_addr  = 0;
                                 err = 0;
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 5dd938579eeb..7c992fbbc2c3 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -103,6 +103,7 @@
                                            - '3' from resolv.h */
 
 #define NONE __constant_htonl(INADDR_NONE)
+#define ANY __constant_htonl(INADDR_ANY)
 
 /*
  * Public IP configuration
@@ -1479,19 +1480,19 @@ static int __init ip_auto_config_setup(char *addrs)
                         DBG(("IP-Config: Parameter #%d: `%s'\n", num, ip));
                         switch (num) {
                         case 0:
-                                if ((ic_myaddr = in_aton(ip)) == INADDR_ANY)
+                                if ((ic_myaddr = in_aton(ip)) == ANY)
                                         ic_myaddr = NONE;
                                 break;
                         case 1:
-                                if ((ic_servaddr = in_aton(ip)) == INADDR_ANY)
+                                if ((ic_servaddr = in_aton(ip)) == ANY)
                                         ic_servaddr = NONE;
                                 break;
                         case 2:
-                                if ((ic_gateway = in_aton(ip)) == INADDR_ANY)
+                                if ((ic_gateway = in_aton(ip)) == ANY)
                                         ic_gateway = NONE;
                                 break;
                         case 3:
-                                if ((ic_netmask = in_aton(ip)) == INADDR_ANY)
+                                if ((ic_netmask = in_aton(ip)) == ANY)
                                         ic_netmask = NONE;
                                 break;
                         case 4:
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index ad0a4069b95b..7a7646a9565c 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -337,14 +337,14 @@ static int sctp_v4_cmp_addr(const union sctp_addr *addr1,
 static void sctp_v4_inaddr_any(union sctp_addr *addr, __be16 port)
 {
         addr->v4.sin_family = AF_INET;
-        addr->v4.sin_addr.s_addr = INADDR_ANY;
+        addr->v4.sin_addr.s_addr = htonl(INADDR_ANY);
         addr->v4.sin_port = port;
 }
 
 /* Is this a wildcard address? */
 static int sctp_v4_is_any(const union sctp_addr *addr)
 {
-        return INADDR_ANY == addr->v4.sin_addr.s_addr;
+        return htonl(INADDR_ANY) == addr->v4.sin_addr.s_addr;
 }
 
 /* This function checks if the address is a valid address to be used for
@@ -375,7 +375,7 @@ static int sctp_v4_available(union sctp_addr *addr, struct sctp_sock *sp)
         int ret = inet_addr_type(&init_net, addr->v4.sin_addr.s_addr);
 
 
-        if (addr->v4.sin_addr.s_addr != INADDR_ANY &&
+        if (addr->v4.sin_addr.s_addr != htonl(INADDR_ANY) &&
            ret != RTN_LOCAL &&
            !sp->inet.freebind &&
            !sysctl_ip_nonlocal_bind)
@@ -785,8 +785,8 @@ static int sctp_inet_cmp_addr(const union sctp_addr *addr1,
         /* PF_INET only supports AF_INET addresses. */
         if (addr1->sa.sa_family != addr2->sa.sa_family)
                 return 0;
-        if (INADDR_ANY == addr1->v4.sin_addr.s_addr ||
-            INADDR_ANY == addr2->v4.sin_addr.s_addr)
+        if (htonl(INADDR_ANY) == addr1->v4.sin_addr.s_addr ||
+            htonl(INADDR_ANY) == addr2->v4.sin_addr.s_addr)
                 return 1;
         if (addr1->v4.sin_addr.s_addr == addr2->v4.sin_addr.s_addr)
                 return 1;
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index ea377e06afae..332eb47539e1 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -185,7 +185,7 @@ int svc_create_xprt(struct svc_serv *serv, char *xprt_name, unsigned short port,
         struct svc_xprt_class *xcl;
         struct sockaddr_in sin = {
                 .sin_family             = AF_INET,
-                .sin_addr.s_addr        = INADDR_ANY,
+                .sin_addr.s_addr        = htonl(INADDR_ANY),
                 .sin_port               = htons(port),
         };
         dprintk("svc: creating transport %s[%d]\n", xprt_name, port);