diff options
author | Ralph Campbell <ralph.campbell@qlogic.com> | 2010-05-25 15:22:33 -0400 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2010-05-26 00:09:43 -0400 |
commit | 7e3a1f4ab1a550dd6cf62a23aabedbad0d23e2d7 (patch) | |
tree | 4d7c48e324527b363656738045d56eb395e96f2e | |
parent | ec96e2fe954c23a54bfdf2673437a39e193a1822 (diff) |
IB/qib: Fix undefined symbol error when CONFIG_PCI_MSI=n
This patch fixes a compile error saying qib_init_iba6120_funcs() is
undefined when CONFIG_PCI_MSI is not defined. Thanks to Randy Dunlap
<randy.dunlap@oracle.com> for finding this and suggesting the fix.
Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
-rw-r--r-- | drivers/infiniband/hw/qib/qib_iba6120.c | 12 | ||||
-rw-r--r-- | drivers/infiniband/hw/qib/qib_init.c | 6 |
2 files changed, 6 insertions, 12 deletions
diff --git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c index 7b6549fd429b..1eadadc13da8 100644 --- a/drivers/infiniband/hw/qib/qib_iba6120.c +++ b/drivers/infiniband/hw/qib/qib_iba6120.c | |||
@@ -3475,14 +3475,6 @@ struct qib_devdata *qib_init_iba6120_funcs(struct pci_dev *pdev, | |||
3475 | struct qib_devdata *dd; | 3475 | struct qib_devdata *dd; |
3476 | int ret; | 3476 | int ret; |
3477 | 3477 | ||
3478 | #ifndef CONFIG_PCI_MSI | ||
3479 | qib_early_err(&pdev->dev, "QLogic PCIE device 0x%x cannot " | ||
3480 | "work if CONFIG_PCI_MSI is not enabled\n", | ||
3481 | ent->device); | ||
3482 | dd = ERR_PTR(-ENODEV); | ||
3483 | goto bail; | ||
3484 | #endif | ||
3485 | |||
3486 | dd = qib_alloc_devdata(pdev, sizeof(struct qib_pportdata) + | 3478 | dd = qib_alloc_devdata(pdev, sizeof(struct qib_pportdata) + |
3487 | sizeof(struct qib_chip_specific)); | 3479 | sizeof(struct qib_chip_specific)); |
3488 | if (IS_ERR(dd)) | 3480 | if (IS_ERR(dd)) |
@@ -3554,10 +3546,6 @@ struct qib_devdata *qib_init_iba6120_funcs(struct pci_dev *pdev, | |||
3554 | if (qib_mini_init) | 3546 | if (qib_mini_init) |
3555 | goto bail; | 3547 | goto bail; |
3556 | 3548 | ||
3557 | #ifndef CONFIG_PCI_MSI | ||
3558 | qib_dev_err(dd, "PCI_MSI not configured, NO interrupts\n"); | ||
3559 | #endif | ||
3560 | |||
3561 | if (qib_pcie_params(dd, 8, NULL, NULL)) | 3549 | if (qib_pcie_params(dd, 8, NULL, NULL)) |
3562 | qib_dev_err(dd, "Failed to setup PCIe or interrupts; " | 3550 | qib_dev_err(dd, "Failed to setup PCIe or interrupts; " |
3563 | "continuing anyway\n"); | 3551 | "continuing anyway\n"); |
diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c index c0139c07e97e..9b40f345ac3f 100644 --- a/drivers/infiniband/hw/qib/qib_init.c +++ b/drivers/infiniband/hw/qib/qib_init.c | |||
@@ -1237,7 +1237,13 @@ static int __devinit qib_init_one(struct pci_dev *pdev, | |||
1237 | */ | 1237 | */ |
1238 | switch (ent->device) { | 1238 | switch (ent->device) { |
1239 | case PCI_DEVICE_ID_QLOGIC_IB_6120: | 1239 | case PCI_DEVICE_ID_QLOGIC_IB_6120: |
1240 | #ifdef CONFIG_PCI_MSI | ||
1240 | dd = qib_init_iba6120_funcs(pdev, ent); | 1241 | dd = qib_init_iba6120_funcs(pdev, ent); |
1242 | #else | ||
1243 | qib_early_err(&pdev->dev, "QLogic PCIE device 0x%x cannot " | ||
1244 | "work if CONFIG_PCI_MSI is not enabled\n", | ||
1245 | ent->device); | ||
1246 | #endif | ||
1241 | break; | 1247 | break; |
1242 | 1248 | ||
1243 | case PCI_DEVICE_ID_QLOGIC_IB_7220: | 1249 | case PCI_DEVICE_ID_QLOGIC_IB_7220: |