aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohannes Berg <johannes@sipsolutions.net>2008-02-25 10:27:44 -0500
committerJohn W. Linville <linville@tuxdriver.com>2008-02-29 15:42:02 -0500
commit6f48422a29714ed92f6136d9e7d3ff39c75607d7 (patch)
treeb42ae88b9cf4163c15d2b3fc7a46dfdbc97e816c
parente6a5ddf20886206caf1c4a2431f6ff01198ab0f7 (diff)
mac80211: remove STA infos last_ack stuff
These things aren't used and the only possible use is within rate control algorithms, however those can, if they need it, keep track of it in their private data. last_ack_ms isn't even updated so completely useless. Signed-off-by: Johannes Berg <johannes@sipsolutions.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r--net/mac80211/debugfs_sta.c29
-rw-r--r--net/mac80211/rc80211_pid_algo.c3
-rw-r--r--net/mac80211/rc80211_simple.c3
-rw-r--r--net/mac80211/sta_info.h4
4 files changed, 0 insertions, 39 deletions
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 1a4d2c3775af..ed7c9f3b4602 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -98,31 +98,6 @@ static ssize_t sta_num_ps_buf_frames_read(struct file *file,
98} 98}
99STA_OPS(num_ps_buf_frames); 99STA_OPS(num_ps_buf_frames);
100 100
101static ssize_t sta_last_ack_rssi_read(struct file *file, char __user *userbuf,
102 size_t count, loff_t *ppos)
103{
104 char buf[100];
105 struct sta_info *sta = file->private_data;
106 int res = scnprintf(buf, sizeof(buf), "%d %d %d\n",
107 sta->last_ack_rssi[0],
108 sta->last_ack_rssi[1],
109 sta->last_ack_rssi[2]);
110 return simple_read_from_buffer(userbuf, count, ppos, buf, res);
111}
112STA_OPS(last_ack_rssi);
113
114static ssize_t sta_last_ack_ms_read(struct file *file, char __user *userbuf,
115 size_t count, loff_t *ppos)
116{
117 char buf[20];
118 struct sta_info *sta = file->private_data;
119 int res = scnprintf(buf, sizeof(buf), "%d\n",
120 sta->last_ack ?
121 jiffies_to_msecs(jiffies - sta->last_ack) : -1);
122 return simple_read_from_buffer(userbuf, count, ppos, buf, res);
123}
124STA_OPS(last_ack_ms);
125
126static ssize_t sta_inactive_ms_read(struct file *file, char __user *userbuf, 101static ssize_t sta_inactive_ms_read(struct file *file, char __user *userbuf,
127 size_t count, loff_t *ppos) 102 size_t count, loff_t *ppos)
128{ 103{
@@ -311,8 +286,6 @@ void ieee80211_sta_debugfs_add(struct sta_info *sta)
311 286
312 DEBUGFS_ADD(flags); 287 DEBUGFS_ADD(flags);
313 DEBUGFS_ADD(num_ps_buf_frames); 288 DEBUGFS_ADD(num_ps_buf_frames);
314 DEBUGFS_ADD(last_ack_rssi);
315 DEBUGFS_ADD(last_ack_ms);
316 DEBUGFS_ADD(inactive_ms); 289 DEBUGFS_ADD(inactive_ms);
317 DEBUGFS_ADD(last_seq_ctrl); 290 DEBUGFS_ADD(last_seq_ctrl);
318#ifdef CONFIG_MAC80211_DEBUG_COUNTERS 291#ifdef CONFIG_MAC80211_DEBUG_COUNTERS
@@ -326,8 +299,6 @@ void ieee80211_sta_debugfs_remove(struct sta_info *sta)
326{ 299{
327 DEBUGFS_DEL(flags); 300 DEBUGFS_DEL(flags);
328 DEBUGFS_DEL(num_ps_buf_frames); 301 DEBUGFS_DEL(num_ps_buf_frames);
329 DEBUGFS_DEL(last_ack_rssi);
330 DEBUGFS_DEL(last_ack_ms);
331 DEBUGFS_DEL(inactive_ms); 302 DEBUGFS_DEL(inactive_ms);
332 DEBUGFS_DEL(last_seq_ctrl); 303 DEBUGFS_DEL(last_seq_ctrl);
333#ifdef CONFIG_MAC80211_DEBUG_COUNTERS 304#ifdef CONFIG_MAC80211_DEBUG_COUNTERS
diff --git a/net/mac80211/rc80211_pid_algo.c b/net/mac80211/rc80211_pid_algo.c
index da8462bbd5f4..9762803e4876 100644
--- a/net/mac80211/rc80211_pid_algo.c
+++ b/net/mac80211/rc80211_pid_algo.c
@@ -280,9 +280,6 @@ static void rate_control_pid_tx_status(void *priv, struct net_device *dev,
280 sta->tx_num_consecutive_failures++; 280 sta->tx_num_consecutive_failures++;
281 sta->tx_num_mpdu_fail++; 281 sta->tx_num_mpdu_fail++;
282 } else { 282 } else {
283 sta->last_ack_rssi[0] = sta->last_ack_rssi[1];
284 sta->last_ack_rssi[1] = sta->last_ack_rssi[2];
285 sta->last_ack_rssi[2] = status->ack_signal;
286 sta->tx_num_consecutive_failures = 0; 283 sta->tx_num_consecutive_failures = 0;
287 sta->tx_num_mpdu_ok++; 284 sta->tx_num_mpdu_ok++;
288 } 285 }
diff --git a/net/mac80211/rc80211_simple.c b/net/mac80211/rc80211_simple.c
index a669bcb8739f..bcc541d4b95c 100644
--- a/net/mac80211/rc80211_simple.c
+++ b/net/mac80211/rc80211_simple.c
@@ -131,9 +131,6 @@ static void rate_control_simple_tx_status(void *priv, struct net_device *dev,
131 sta->tx_num_consecutive_failures++; 131 sta->tx_num_consecutive_failures++;
132 sta->tx_num_mpdu_fail++; 132 sta->tx_num_mpdu_fail++;
133 } else { 133 } else {
134 sta->last_ack_rssi[0] = sta->last_ack_rssi[1];
135 sta->last_ack_rssi[1] = sta->last_ack_rssi[2];
136 sta->last_ack_rssi[2] = status->ack_signal;
137 sta->tx_num_consecutive_failures = 0; 134 sta->tx_num_consecutive_failures = 0;
138 sta->tx_num_mpdu_ok++; 135 sta->tx_num_mpdu_ok++;
139 } 136 }
diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h
index 7b5be309fe0a..86eed40ada78 100644
--- a/net/mac80211/sta_info.h
+++ b/net/mac80211/sta_info.h
@@ -177,8 +177,6 @@ struct sta_info {
177 int last_rssi; /* RSSI of last received frame from this STA */ 177 int last_rssi; /* RSSI of last received frame from this STA */
178 int last_signal; /* signal of last received frame from this STA */ 178 int last_signal; /* signal of last received frame from this STA */
179 int last_noise; /* noise of last received frame from this STA */ 179 int last_noise; /* noise of last received frame from this STA */
180 int last_ack_rssi[3]; /* RSSI of last received ACKs from this STA */
181 unsigned long last_ack;
182 int channel_use; 180 int channel_use;
183 int channel_use_raw; 181 int channel_use_raw;
184 182
@@ -200,8 +198,6 @@ struct sta_info {
200 struct dentry *dir; 198 struct dentry *dir;
201 struct dentry *flags; 199 struct dentry *flags;
202 struct dentry *num_ps_buf_frames; 200 struct dentry *num_ps_buf_frames;
203 struct dentry *last_ack_rssi;
204 struct dentry *last_ack_ms;
205 struct dentry *inactive_ms; 201 struct dentry *inactive_ms;
206 struct dentry *last_seq_ctrl; 202 struct dentry *last_seq_ctrl;
207#ifdef CONFIG_MAC80211_DEBUG_COUNTERS 203#ifdef CONFIG_MAC80211_DEBUG_COUNTERS