aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIan Campbell <Ian.Campbell@citrix.com>2008-10-10 06:27:38 -0400
committerIngo Molnar <mingo@elte.hu>2008-10-10 07:00:15 -0400
commit5dc64a3442b98eaa0e3730c35fcf00cf962a93e7 (patch)
tree4023600dc25e00ca34927cd05232dbbd75e91c6d
parenteefb47f6a1e855653d275cb90592a3587ea93a09 (diff)
xen: do not reserve 2 pages of padding between hypervisor and fixmap.
When reserving space for the hypervisor the Xen paravirt backend adds an extra two pages (this was carried forward from the 2.6.18-xen tree which had them "for safety"). Depending on various CONFIG options this can cause the boot time fixmaps to span multiple PMDs which is not supported and triggers a WARN in early_ioremap_init(). This was exposed by 2216d199b1430d1c0affb1498a9ebdbd9c0de439 which moved the dmi table parsing earlier. x86: fix CONFIG_X86_RESERVE_LOW_64K=y The bad_bios_dmi_table() quirk never triggered because we do DMI setup too late. Move it a bit earlier. There is no real reason to reserve these two extra pages and the fixmap already incorporates FIX_HOLE which serves the same purpose. None of the other callers of reserve_top_address do this. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/xen/enlighten.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 85692c9f6496..977a54255fb4 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1370,7 +1370,7 @@ static void __init xen_reserve_top(void)
1370 if (HYPERVISOR_xen_version(XENVER_platform_parameters, &pp) == 0) 1370 if (HYPERVISOR_xen_version(XENVER_platform_parameters, &pp) == 0)
1371 top = pp.virt_start; 1371 top = pp.virt_start;
1372 1372
1373 reserve_top_address(-top + 2 * PAGE_SIZE); 1373 reserve_top_address(-top);
1374#endif /* CONFIG_X86_32 */ 1374#endif /* CONFIG_X86_32 */
1375} 1375}
1376 1376