aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2007-08-07 16:43:14 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-08-09 11:34:23 -0400
commit6a0ed91e361a93ee1efb4c20c4967024ed2a8dd7 (patch)
treeb4299ccdb180450b5ed7a621dad4f3ed0f4abdae
parent660ca5317d229ca27dec6a3159423bc0c5291c2d (diff)
hexdump: use const notation
Trivial fix: mark the buffer to hexdump as const so callers could avoid casting their const buffers when calling print_hex_dump(). The patch is really trivial and I suggest to consider it as a fix (it fixes GCC warnings) and push it to current tree. Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--include/linux/kernel.h2
-rw-r--r--lib/hexdump.c4
2 files changed, 3 insertions, 3 deletions
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 4300bb462d29..b4f5b81b4257 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -224,7 +224,7 @@ extern void hex_dump_to_buffer(const void *buf, size_t len,
224 char *linebuf, size_t linebuflen, bool ascii); 224 char *linebuf, size_t linebuflen, bool ascii);
225extern void print_hex_dump(const char *level, const char *prefix_str, 225extern void print_hex_dump(const char *level, const char *prefix_str,
226 int prefix_type, int rowsize, int groupsize, 226 int prefix_type, int rowsize, int groupsize,
227 void *buf, size_t len, bool ascii); 227 const void *buf, size_t len, bool ascii);
228extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type, 228extern void print_hex_dump_bytes(const char *prefix_str, int prefix_type,
229 void *buf, size_t len); 229 void *buf, size_t len);
230#define hex_asc(x) "0123456789abcdef"[x] 230#define hex_asc(x) "0123456789abcdef"[x]
diff --git a/lib/hexdump.c b/lib/hexdump.c
index 473f5aed6cae..16f2e2935e87 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -145,9 +145,9 @@ EXPORT_SYMBOL(hex_dump_to_buffer);
145 */ 145 */
146void print_hex_dump(const char *level, const char *prefix_str, int prefix_type, 146void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
147 int rowsize, int groupsize, 147 int rowsize, int groupsize,
148 void *buf, size_t len, bool ascii) 148 const void *buf, size_t len, bool ascii)
149{ 149{
150 u8 *ptr = buf; 150 const u8 *ptr = buf;
151 int i, linelen, remaining = len; 151 int i, linelen, remaining = len;
152 unsigned char linebuf[200]; 152 unsigned char linebuf[200];
153 153