diff options
author | Eric Dumazet <dada1@cosmosbay.com> | 2008-01-08 04:35:52 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-01-28 18:00:49 -0500 |
commit | 6666351df90656677723f8232b3fdd26a500e51e (patch) | |
tree | bdbc17a38c257153e9f70fed37cc06c643644648 | |
parent | 40ccbf525e55fc6d1f3a88c1e98b13db4dd618db (diff) |
[XFRM]: xfrm_state_clone() should be static, not exported
xfrm_state_clone() is not used outside of net/xfrm/xfrm_state.c
There is no need to export it.
Spoted by sparse checker.
CHECK net/xfrm/xfrm_state.c
net/xfrm/xfrm_state.c:1103:19: warning: symbol 'xfrm_state_clone' was not
declared. Should it be static?
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/xfrm/xfrm_state.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 2585e4b0d27f..3003503d0c94 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c | |||
@@ -1100,7 +1100,7 @@ out: | |||
1100 | EXPORT_SYMBOL(xfrm_state_add); | 1100 | EXPORT_SYMBOL(xfrm_state_add); |
1101 | 1101 | ||
1102 | #ifdef CONFIG_XFRM_MIGRATE | 1102 | #ifdef CONFIG_XFRM_MIGRATE |
1103 | struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp) | 1103 | static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp) |
1104 | { | 1104 | { |
1105 | int err = -ENOMEM; | 1105 | int err = -ENOMEM; |
1106 | struct xfrm_state *x = xfrm_state_alloc(); | 1106 | struct xfrm_state *x = xfrm_state_alloc(); |
@@ -1175,7 +1175,6 @@ struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig, int *errp) | |||
1175 | kfree(x); | 1175 | kfree(x); |
1176 | return NULL; | 1176 | return NULL; |
1177 | } | 1177 | } |
1178 | EXPORT_SYMBOL(xfrm_state_clone); | ||
1179 | 1178 | ||
1180 | /* xfrm_state_lock is held */ | 1179 | /* xfrm_state_lock is held */ |
1181 | struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m) | 1180 | struct xfrm_state * xfrm_migrate_state_find(struct xfrm_migrate *m) |