diff options
author | Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com> | 2007-10-16 04:28:52 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 12:43:15 -0400 |
commit | 5a258d032d8dff1c5e28ce64c47ac4577c2c5a70 (patch) | |
tree | 49b66c1cd22bc0c9628df6003d17518b477c3c0d | |
parent | 42b558d51cb0c8a83a17f22b3ec4325176d1797e (diff) |
fbdev: fb_create_modedb() non-static `int first = 1;'
Looking at the code flow, `int first' in fb_create_modedb() should be static.
[adaplas]
Better for 'int first' to be moved outside the loop.
[akpm@linux-foundation.org: kill stray semicolon]
Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/video/fbmon.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 438b9411905c..4ba9c0894416 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c | |||
@@ -591,7 +591,7 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize) | |||
591 | { | 591 | { |
592 | struct fb_videomode *mode, *m; | 592 | struct fb_videomode *mode, *m; |
593 | unsigned char *block; | 593 | unsigned char *block; |
594 | int num = 0, i; | 594 | int num = 0, i, first = 1; |
595 | 595 | ||
596 | mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL); | 596 | mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL); |
597 | if (mode == NULL) | 597 | if (mode == NULL) |
@@ -608,8 +608,6 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize) | |||
608 | DPRINTK(" Detailed Timings\n"); | 608 | DPRINTK(" Detailed Timings\n"); |
609 | block = edid + DETAILED_TIMING_DESCRIPTIONS_START; | 609 | block = edid + DETAILED_TIMING_DESCRIPTIONS_START; |
610 | for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) { | 610 | for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) { |
611 | int first = 1; | ||
612 | |||
613 | if (!(block[0] == 0x00 && block[1] == 0x00)) { | 611 | if (!(block[0] == 0x00 && block[1] == 0x00)) { |
614 | get_detailed_timing(block, &mode[num]); | 612 | get_detailed_timing(block, &mode[num]); |
615 | if (first) { | 613 | if (first) { |