aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian King <brking@linux.vnet.ibm.com>2009-05-28 17:17:22 -0400
committerJames Bottomley <James.Bottomley@HansenPartnership.com>2009-06-08 14:07:29 -0400
commit4a2837d4fcaf8a2c2ad61523287073d0c14b9ed0 (patch)
tree9c5a664d6c5b2ca63daa5907c66d6a644a0bc1e5
parent601e7638254c118fca135af9b1a9f35061420f62 (diff)
[SCSI] ibmvfc: Fix invalid error response handling
Fix an obvious bug in processing error responses for SCSI commands which can result in successful responses being incorrectly returned with DID_ERROR. Signed-off-by: Brian King <brking@linux.vnet.ibm.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
-rw-r--r--drivers/scsi/ibmvscsi/ibmvfc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index ea4abee7a2a9..879c51133c95 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -275,7 +275,7 @@ static int ibmvfc_get_err_result(struct ibmvfc_cmd *vfc_cmd)
275 int fc_rsp_len = rsp->fcp_rsp_len; 275 int fc_rsp_len = rsp->fcp_rsp_len;
276 276
277 if ((rsp->flags & FCP_RSP_LEN_VALID) && 277 if ((rsp->flags & FCP_RSP_LEN_VALID) &&
278 ((!fc_rsp_len && fc_rsp_len != 4 && fc_rsp_len != 8) || 278 ((fc_rsp_len && fc_rsp_len != 4 && fc_rsp_len != 8) ||
279 rsp->data.info.rsp_code)) 279 rsp->data.info.rsp_code))
280 return DID_ERROR << 16; 280 return DID_ERROR << 16;
281 281