aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Dike <jdike@addtoit.com>2006-01-06 03:18:48 -0500
committerLinus Torvalds <torvalds@g5.osdl.org>2006-01-06 11:33:45 -0500
commit970d6e3a3461ebc62bc3fc6d4962c936cb2ed97c (patch)
tree0af12c696e86ec294d966c704821f806b6e28883
parent118c1f27b838c5d1cf5338dc5abff52ceb364826 (diff)
[PATCH] uml: use kstrdup
There were a bunch of calls to uml_strdup dating from before kstrdup was introduced. This changes those calls. It doesn't eliminate the definition since there is still a couple of calls in userspace code (which should probably call the libc strdup). Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--arch/um/drivers/line.c10
-rw-r--r--arch/um/drivers/mconsole_kern.c2
-rw-r--r--arch/um/drivers/net_kern.c2
-rw-r--r--arch/um/drivers/ubd_kern.c2
4 files changed, 8 insertions, 8 deletions
diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index e0fdffa2d542..c31fc541e210 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -562,10 +562,11 @@ int line_setup(struct line *lines, unsigned int num, char *init, int all_allowed
562 562
563int line_config(struct line *lines, unsigned int num, char *str) 563int line_config(struct line *lines, unsigned int num, char *str)
564{ 564{
565 char *new = uml_strdup(str); 565 char *new;
566 566
567 new = kstrdup(str, GFP_KERNEL);
567 if(new == NULL){ 568 if(new == NULL){
568 printk("line_config - uml_strdup failed\n"); 569 printk("line_config - kstrdup failed\n");
569 return -ENOMEM; 570 return -ENOMEM;
570 } 571 }
571 return !line_setup(lines, num, new, 0); 572 return !line_setup(lines, num, new, 0);
@@ -677,10 +678,9 @@ void lines_init(struct line *lines, int nlines)
677 INIT_LIST_HEAD(&line->chan_list); 678 INIT_LIST_HEAD(&line->chan_list);
678 spin_lock_init(&line->lock); 679 spin_lock_init(&line->lock);
679 if(line->init_str != NULL){ 680 if(line->init_str != NULL){
680 line->init_str = uml_strdup(line->init_str); 681 line->init_str = kstrdup(line->init_str, GFP_KERNEL);
681 if(line->init_str == NULL) 682 if(line->init_str == NULL)
682 printk("lines_init - uml_strdup returned " 683 printk("lines_init - kstrdup returned NULL\n");
683 "NULL\n");
684 } 684 }
685 } 685 }
686} 686}
diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
index 12c95368124a..b36786410453 100644
--- a/arch/um/drivers/mconsole_kern.c
+++ b/arch/um/drivers/mconsole_kern.c
@@ -563,7 +563,7 @@ int mconsole_init(void)
563 } 563 }
564 564
565 if(notify_socket != NULL){ 565 if(notify_socket != NULL){
566 notify_socket = uml_strdup(notify_socket); 566 notify_socket = kstrdup(notify_socket, GFP_KERNEL);
567 if(notify_socket != NULL) 567 if(notify_socket != NULL)
568 mconsole_notify(notify_socket, MCONSOLE_SOCKET, 568 mconsole_notify(notify_socket, MCONSOLE_SOCKET,
569 mconsole_socket_name, 569 mconsole_socket_name,
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index 84c73a300acb..29785f643021 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -586,7 +586,7 @@ static int net_config(char *str)
586 err = eth_parse(str, &n, &str); 586 err = eth_parse(str, &n, &str);
587 if(err) return(err); 587 if(err) return(err);
588 588
589 str = uml_strdup(str); 589 str = kstrdup(str, GFP_KERNEL);
590 if(str == NULL){ 590 if(str == NULL){
591 printk(KERN_ERR "net_config failed to strdup string\n"); 591 printk(KERN_ERR "net_config failed to strdup string\n");
592 return(-1); 592 return(-1);
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 93898917cbe5..1fe0dcd9f464 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -706,7 +706,7 @@ static int ubd_config(char *str)
706{ 706{
707 int n, err; 707 int n, err;
708 708
709 str = uml_strdup(str); 709 str = kstrdup(str, GFP_KERNEL);
710 if(str == NULL){ 710 if(str == NULL){
711 printk(KERN_ERR "ubd_config failed to strdup string\n"); 711 printk(KERN_ERR "ubd_config failed to strdup string\n");
712 return(1); 712 return(1);