aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2006-06-26 03:27:36 -0400
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-26 12:58:36 -0400
commit8932c2e0dcae52e73430878fd8a7a7800176eada (patch)
tree3b734ccaa0fb210f1fd76ff9bb6fb9700d1c4095
parentc70810b327a247d12805554d0aa4605e257effb8 (diff)
[PATCH] md: remove arbitrary limit on chunk size
The largest chunk size the code can support without substantial surgery is 2^30 bytes, so make that the limit instead of an arbitrary 4Meg. Some day, the 'chunksize' should change to a sector-shift instead of a byte-count. Then no limit would be needed. Signed-off-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/md/raid10.c2
-rw-r--r--drivers/md/raid5.c4
-rw-r--r--drivers/md/raid6main.c4
-rw-r--r--include/linux/raid/md_k.h3
4 files changed, 7 insertions, 6 deletions
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 1440935414e6..affeaefd4033 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -2050,7 +2050,7 @@ static int run(mddev_t *mddev)
2050 * maybe... 2050 * maybe...
2051 */ 2051 */
2052 { 2052 {
2053 int stripe = conf->raid_disks * mddev->chunk_size / PAGE_SIZE; 2053 int stripe = conf->raid_disks * (mddev->chunk_size / PAGE_SIZE);
2054 stripe /= conf->near_copies; 2054 stripe /= conf->near_copies;
2055 if (mddev->queue->backing_dev_info.ra_pages < 2* stripe) 2055 if (mddev->queue->backing_dev_info.ra_pages < 2* stripe)
2056 mddev->queue->backing_dev_info.ra_pages = 2* stripe; 2056 mddev->queue->backing_dev_info.ra_pages = 2* stripe;
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 31843604049c..122e64e557b1 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -2382,8 +2382,8 @@ static int run(mddev_t *mddev)
2382 * 2 * (n-1) * chunksize where 'n' is the number of raid devices 2382 * 2 * (n-1) * chunksize where 'n' is the number of raid devices
2383 */ 2383 */
2384 { 2384 {
2385 int stripe = (mddev->raid_disks-1) * mddev->chunk_size 2385 int stripe = (mddev->raid_disks-1) *
2386 / PAGE_SIZE; 2386 (mddev->chunk_size / PAGE_SIZE);
2387 if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe) 2387 if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe)
2388 mddev->queue->backing_dev_info.ra_pages = 2 * stripe; 2388 mddev->queue->backing_dev_info.ra_pages = 2 * stripe;
2389 } 2389 }
diff --git a/drivers/md/raid6main.c b/drivers/md/raid6main.c
index bc69355e0100..e53d2d96ea3a 100644
--- a/drivers/md/raid6main.c
+++ b/drivers/md/raid6main.c
@@ -2135,8 +2135,8 @@ static int run(mddev_t *mddev)
2135 * 2 * (n-2) * chunksize where 'n' is the number of raid devices 2135 * 2 * (n-2) * chunksize where 'n' is the number of raid devices
2136 */ 2136 */
2137 { 2137 {
2138 int stripe = (mddev->raid_disks-2) * mddev->chunk_size 2138 int stripe = (mddev->raid_disks-2) *
2139 / PAGE_SIZE; 2139 (mddev->chunk_size / PAGE_SIZE);
2140 if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe) 2140 if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe)
2141 mddev->queue->backing_dev_info.ra_pages = 2 * stripe; 2141 mddev->queue->backing_dev_info.ra_pages = 2 * stripe;
2142 } 2142 }
diff --git a/include/linux/raid/md_k.h b/include/linux/raid/md_k.h
index e2df61f5b09a..db2ca2d9066e 100644
--- a/include/linux/raid/md_k.h
+++ b/include/linux/raid/md_k.h
@@ -40,7 +40,8 @@ typedef struct mdk_rdev_s mdk_rdev_t;
40 * options passed in raidrun: 40 * options passed in raidrun:
41 */ 41 */
42 42
43#define MAX_CHUNK_SIZE (4096*1024) 43/* Currently this must fix in an 'int' */
44#define MAX_CHUNK_SIZE (1<<30)
44 45
45/* 46/*
46 * MD's 'extended' device 47 * MD's 'extended' device