diff options
author | Antonino A. Daplas <adaplas@gmail.com> | 2005-09-09 16:10:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-09 17:03:40 -0400 |
commit | 61ab7903b8cd772d3bfb28bc26d02c599cfb0e5b (patch) | |
tree | 4140b59ec3882a954b620ebbee56d6c7bcdf781d | |
parent | 7c1cd6fd5efeb95603e37f35b5da293b452d8b64 (diff) |
[PATCH] fbdev: Initialize var structure in calc_mode_timings
The var structure in calc_mode_timings is not properly initialized (zero set)
which leads to undefined behavior when it is passed to fb_get_mode().
Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/video/fbmon.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 791bec3d672a..713226cdf3c6 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c | |||
@@ -314,11 +314,13 @@ static int edid_is_monitor_block(unsigned char *block) | |||
314 | return 0; | 314 | return 0; |
315 | } | 315 | } |
316 | 316 | ||
317 | static void calc_mode_timings(int xres, int yres, int refresh, struct fb_videomode *mode) | 317 | static void calc_mode_timings(int xres, int yres, int refresh, |
318 | struct fb_videomode *mode) | ||
318 | { | 319 | { |
319 | struct fb_var_screeninfo var; | 320 | struct fb_var_screeninfo var; |
320 | struct fb_info info; | 321 | struct fb_info info; |
321 | 322 | ||
323 | memset(&var, 0, sizeof(struct fb_var_screeninfo)); | ||
322 | var.xres = xres; | 324 | var.xres = xres; |
323 | var.yres = yres; | 325 | var.yres = yres; |
324 | fb_get_mode(FB_VSYNCTIMINGS | FB_IGNOREMON, | 326 | fb_get_mode(FB_VSYNCTIMINGS | FB_IGNOREMON, |