aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMilton Miller <miltonm@bga.com>2008-10-09 21:56:39 -0400
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2008-10-13 01:24:19 -0400
commit2172fe8704a1df7cbb988ae1ec4edbfef3e28860 (patch)
tree91b678287eb18dba39710966414569467f167dc9
parentd879f3849c93743e170a8dc60a8dfb66150c420d (diff)
powerpc/xics: Make printk format strings fit on one line
Several printks were broken at word boundaries for line length. Some even referred to old function names. Using __func__ and changing the text slightly for the format allows these printk formats to fit on one line. Signed-off-by: Milton Miller <miltonm@bga.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--arch/powerpc/platforms/pseries/xics.c36
1 files changed, 18 insertions, 18 deletions
diff --git a/arch/powerpc/platforms/pseries/xics.c b/arch/powerpc/platforms/pseries/xics.c
index 5ba3e0092960..62b0400577de 100644
--- a/arch/powerpc/platforms/pseries/xics.c
+++ b/arch/powerpc/platforms/pseries/xics.c
@@ -201,17 +201,17 @@ static void xics_unmask_irq(unsigned int virq)
201 call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq, server, 201 call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq, server,
202 DEFAULT_PRIORITY); 202 DEFAULT_PRIORITY);
203 if (call_status != 0) { 203 if (call_status != 0) {
204 printk(KERN_ERR "xics_enable_irq: irq=%u: ibm_set_xive " 204 printk(KERN_ERR
205 "returned %d\n", irq, call_status); 205 "%s: ibm_set_xive irq %u server %x returned %d\n",
206 printk("set_xive %x, server %x\n", ibm_set_xive, server); 206 __func__, irq, server, call_status);
207 return; 207 return;
208 } 208 }
209 209
210 /* Now unmask the interrupt (often a no-op) */ 210 /* Now unmask the interrupt (often a no-op) */
211 call_status = rtas_call(ibm_int_on, 1, 1, NULL, irq); 211 call_status = rtas_call(ibm_int_on, 1, 1, NULL, irq);
212 if (call_status != 0) { 212 if (call_status != 0) {
213 printk(KERN_ERR "xics_enable_irq: irq=%u: ibm_int_on " 213 printk(KERN_ERR "%s: ibm_int_on irq=%u returned %d\n",
214 "returned %d\n", irq, call_status); 214 __func__, irq, call_status);
215 return; 215 return;
216 } 216 }
217} 217}
@@ -232,8 +232,8 @@ static void xics_mask_real_irq(unsigned int irq)
232 232
233 call_status = rtas_call(ibm_int_off, 1, 1, NULL, irq); 233 call_status = rtas_call(ibm_int_off, 1, 1, NULL, irq);
234 if (call_status != 0) { 234 if (call_status != 0) {
235 printk(KERN_ERR "xics_disable_real_irq: irq=%u: " 235 printk(KERN_ERR "%s: ibm_int_off irq=%u returned %d\n",
236 "ibm_int_off returned %d\n", irq, call_status); 236 __func__, irq, call_status);
237 return; 237 return;
238 } 238 }
239 239
@@ -241,8 +241,8 @@ static void xics_mask_real_irq(unsigned int irq)
241 call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq, 241 call_status = rtas_call(ibm_set_xive, 3, 1, NULL, irq,
242 default_server, 0xff); 242 default_server, 0xff);
243 if (call_status != 0) { 243 if (call_status != 0) {
244 printk(KERN_ERR "xics_disable_irq: irq=%u: ibm_set_xive(0xff)" 244 printk(KERN_ERR "%s: ibm_set_xive(0xff) irq=%u returned %d\n",
245 " returned %d\n", irq, call_status); 245 __func__, irq, call_status);
246 return; 246 return;
247 } 247 }
248} 248}
@@ -346,8 +346,8 @@ static void xics_set_affinity(unsigned int virq, cpumask_t cpumask)
346 status = rtas_call(ibm_get_xive, 1, 3, xics_status, irq); 346 status = rtas_call(ibm_get_xive, 1, 3, xics_status, irq);
347 347
348 if (status) { 348 if (status) {
349 printk(KERN_ERR "xics_set_affinity: irq=%u ibm,get-xive " 349 printk(KERN_ERR "%s: ibm,get-xive irq=%u returns %d\n",
350 "returns %d\n", irq, status); 350 __func__, irq, status);
351 return; 351 return;
352 } 352 }
353 353
@@ -359,8 +359,9 @@ static void xics_set_affinity(unsigned int virq, cpumask_t cpumask)
359 if (irq_server == -1) { 359 if (irq_server == -1) {
360 char cpulist[128]; 360 char cpulist[128];
361 cpumask_scnprintf(cpulist, sizeof(cpulist), cpumask); 361 cpumask_scnprintf(cpulist, sizeof(cpulist), cpumask);
362 printk(KERN_WARNING "xics_set_affinity: No online cpus in " 362 printk(KERN_WARNING
363 "the mask %s for irq %d\n", cpulist, virq); 363 "%s: No online cpus in the mask %s for irq %d\n",
364 __func__, cpulist, virq);
364 return; 365 return;
365 } 366 }
366 367
@@ -368,8 +369,8 @@ static void xics_set_affinity(unsigned int virq, cpumask_t cpumask)
368 irq, irq_server, xics_status[1]); 369 irq, irq_server, xics_status[1]);
369 370
370 if (status) { 371 if (status) {
371 printk(KERN_ERR "xics_set_affinity: irq=%u ibm,set-xive " 372 printk(KERN_ERR "%s: ibm,set-xive irq=%u returns %d\n",
372 "returns %d\n", irq, status); 373 __func__, irq, status);
373 return; 374 return;
374 } 375 }
375} 376}
@@ -829,9 +830,8 @@ void xics_migrate_irqs_away(void)
829 830
830 status = rtas_call(ibm_get_xive, 1, 3, xics_status, irq); 831 status = rtas_call(ibm_get_xive, 1, 3, xics_status, irq);
831 if (status) { 832 if (status) {
832 printk(KERN_ERR "migrate_irqs_away: irq=%u " 833 printk(KERN_ERR "%s: ibm,get-xive irq=%u returns %d\n",
833 "ibm,get-xive returns %d\n", 834 __func__, irq, status);
834 virq, status);
835 goto unlock; 835 goto unlock;
836 } 836 }
837 837