aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarvey Harrison <harvey.harrison@gmail.com>2008-10-28 19:06:44 -0400
committerDavid S. Miller <davem@davemloft.net>2008-10-28 19:06:44 -0400
commit1afa67f5e70b4733d5b237df61e6d639af6283bb (patch)
tree34912ebf8e13c40e00bc5ab13c365a5556d684ca
parentb071195deba14b37ce896c26f20349b46e5f9fd2 (diff)
misc: replace NIP6_FMT with %p6 format specifier
The iscsi_ibft.c changes are almost certainly a bugfix as the pointer 'ip' is a u8 *, so they never print the last 8 bytes of the IPv6 address, and the eight bytes they do print have a zero byte with them in each 16-bit word. Other than that, this should cause no difference in functionality. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/firmware/iscsi_ibft.c4
-rw-r--r--drivers/scsi/iscsi_tcp.c2
-rw-r--r--fs/lockd/host.c2
-rw-r--r--fs/nfs/super.c3
-rw-r--r--security/selinux/avc.c2
5 files changed, 5 insertions, 8 deletions
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 4353414a0b77..0a6472097a81 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -290,9 +290,7 @@ static ssize_t sprintf_ipaddr(char *buf, u8 *ip)
290 /* 290 /*
291 * IPv6 291 * IPv6
292 */ 292 */
293 str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]), 293 str += sprintf(str, "%p6", ip);
294 ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]),
295 ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7]));
296 } 294 }
297 str += sprintf(str, "\n"); 295 str += sprintf(str, "\n");
298 return str - buf; 296 return str - buf;
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index ed6c54cae7b1..ef929aef7c12 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -1608,7 +1608,7 @@ static int iscsi_tcp_get_addr(struct iscsi_conn *conn, struct socket *sock,
1608 case AF_INET6: 1608 case AF_INET6:
1609 sin6 = (struct sockaddr_in6 *)addr; 1609 sin6 = (struct sockaddr_in6 *)addr;
1610 spin_lock_bh(&conn->session->lock); 1610 spin_lock_bh(&conn->session->lock);
1611 sprintf(buf, NIP6_FMT, NIP6(sin6->sin6_addr)); 1611 sprintf(buf, "%p6", &sin6->sin6_addr);
1612 *port = be16_to_cpu(sin6->sin6_port); 1612 *port = be16_to_cpu(sin6->sin6_port);
1613 spin_unlock_bh(&conn->session->lock); 1613 spin_unlock_bh(&conn->session->lock);
1614 break; 1614 break;
diff --git a/fs/lockd/host.c b/fs/lockd/host.c
index 9fd8889097b7..344e6b475e05 100644
--- a/fs/lockd/host.c
+++ b/fs/lockd/host.c
@@ -122,7 +122,7 @@ static void nlm_display_address(const struct sockaddr *sap,
122 snprintf(buf, len, NIPQUAD_FMT, 122 snprintf(buf, len, NIPQUAD_FMT,
123 NIPQUAD(sin6->sin6_addr.s6_addr32[3])); 123 NIPQUAD(sin6->sin6_addr.s6_addr32[3]));
124 else 124 else
125 snprintf(buf, len, NIP6_FMT, NIP6(sin6->sin6_addr)); 125 snprintf(buf, len, "%p6", &sin6->sin6_addr);
126 break; 126 break;
127 default: 127 default:
128 snprintf(buf, len, "unsupported address family"); 128 snprintf(buf, len, "unsupported address family");
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index f48db679a1c6..5fe77219df78 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -468,8 +468,7 @@ static void nfs_show_mountd_options(struct seq_file *m, struct nfs_server *nfss,
468 } 468 }
469 case AF_INET6: { 469 case AF_INET6: {
470 struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap; 470 struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap;
471 seq_printf(m, ",mountaddr=" NIP6_FMT, 471 seq_printf(m, ",mountaddr=%p6", &sin6->sin6_addr);
472 NIP6(sin6->sin6_addr));
473 break; 472 break;
474 } 473 }
475 default: 474 default:
diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index cb30c7e350b3..c91008f438a2 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -495,7 +495,7 @@ static inline void avc_print_ipv6_addr(struct audit_buffer *ab,
495 char *name1, char *name2) 495 char *name1, char *name2)
496{ 496{
497 if (!ipv6_addr_any(addr)) 497 if (!ipv6_addr_any(addr))
498 audit_log_format(ab, " %s=" NIP6_FMT, name1, NIP6(*addr)); 498 audit_log_format(ab, " %s=%p6", name1, addr);
499 if (port) 499 if (port)
500 audit_log_format(ab, " %s=%d", name2, ntohs(port)); 500 audit_log_format(ab, " %s=%d", name2, ntohs(port));
501} 501}