diff options
author | Eric Sesterhenn <snakebyte@gmx.de> | 2006-05-31 05:55:17 -0400 |
---|---|---|
committer | Jaroslav Kysela <perex@suse.cz> | 2006-06-22 15:34:05 -0400 |
commit | d20cad602fc3d92902dc3b4ed252359ab05eae0f (patch) | |
tree | b2a2c5ffd6b94317ea26a7a349d44993d95d6dce | |
parent | f26eb78fcfb5b76fbe6d3e740b6fedda611f8395 (diff) |
[ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c
this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r-- | sound/synth/emux/soundfont.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/synth/emux/soundfont.c b/sound/synth/emux/soundfont.c index 7f0bdea0dfd3..455e535933ec 100644 --- a/sound/synth/emux/soundfont.c +++ b/sound/synth/emux/soundfont.c | |||
@@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *sflist, const void __user *data, | |||
195 | break; | 195 | break; |
196 | case SNDRV_SFNT_REMOVE_INFO: | 196 | case SNDRV_SFNT_REMOVE_INFO: |
197 | /* patch must be opened */ | 197 | /* patch must be opened */ |
198 | if (sflist->currsf) { | 198 | if (!sflist->currsf) { |
199 | snd_printk("soundfont: remove_info: patch not opened\n"); | 199 | snd_printk("soundfont: remove_info: patch not opened\n"); |
200 | rc = -EINVAL; | 200 | rc = -EINVAL; |
201 | } else { | 201 | } else { |