diff options
author | Paulius Zaleckas <paulius.zaleckas@teltonika.lt> | 2008-04-28 20:07:31 -0400 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2008-04-29 01:55:14 -0400 |
commit | dfd44151e8888b964b7f2400f26794154a58c86b (patch) | |
tree | 45935b816de61f24a55064fabf9578758525dd84 | |
parent | 815f8802d201aba1ce343ba832daf639165f01a1 (diff) |
3c515: use netstats in net_device structure
Use net_device_stats from net_device structure instead of local.
Signed-off-by: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
-rw-r--r-- | drivers/net/3c515.c | 64 |
1 files changed, 30 insertions, 34 deletions
diff --git a/drivers/net/3c515.c b/drivers/net/3c515.c index 6ab84b661d70..105a8c7ca7e9 100644 --- a/drivers/net/3c515.c +++ b/drivers/net/3c515.c | |||
@@ -310,7 +310,6 @@ struct corkscrew_private { | |||
310 | struct sk_buff *tx_skbuff[TX_RING_SIZE]; | 310 | struct sk_buff *tx_skbuff[TX_RING_SIZE]; |
311 | unsigned int cur_rx, cur_tx; /* The next free ring entry */ | 311 | unsigned int cur_rx, cur_tx; /* The next free ring entry */ |
312 | unsigned int dirty_rx, dirty_tx;/* The ring entries to be free()ed. */ | 312 | unsigned int dirty_rx, dirty_tx;/* The ring entries to be free()ed. */ |
313 | struct net_device_stats stats; | ||
314 | struct sk_buff *tx_skb; /* Packet being eaten by bus master ctrl. */ | 313 | struct sk_buff *tx_skb; /* Packet being eaten by bus master ctrl. */ |
315 | struct timer_list timer; /* Media selection timer. */ | 314 | struct timer_list timer; /* Media selection timer. */ |
316 | int capabilities ; /* Adapter capabilities word. */ | 315 | int capabilities ; /* Adapter capabilities word. */ |
@@ -983,8 +982,8 @@ static void corkscrew_timeout(struct net_device *dev) | |||
983 | break; | 982 | break; |
984 | outw(TxEnable, ioaddr + EL3_CMD); | 983 | outw(TxEnable, ioaddr + EL3_CMD); |
985 | dev->trans_start = jiffies; | 984 | dev->trans_start = jiffies; |
986 | vp->stats.tx_errors++; | 985 | dev->stats.tx_errors++; |
987 | vp->stats.tx_dropped++; | 986 | dev->stats.tx_dropped++; |
988 | netif_wake_queue(dev); | 987 | netif_wake_queue(dev); |
989 | } | 988 | } |
990 | 989 | ||
@@ -1050,7 +1049,7 @@ static int corkscrew_start_xmit(struct sk_buff *skb, | |||
1050 | } | 1049 | } |
1051 | /* Put out the doubleword header... */ | 1050 | /* Put out the doubleword header... */ |
1052 | outl(skb->len, ioaddr + TX_FIFO); | 1051 | outl(skb->len, ioaddr + TX_FIFO); |
1053 | vp->stats.tx_bytes += skb->len; | 1052 | dev->stats.tx_bytes += skb->len; |
1054 | #ifdef VORTEX_BUS_MASTER | 1053 | #ifdef VORTEX_BUS_MASTER |
1055 | if (vp->bus_master) { | 1054 | if (vp->bus_master) { |
1056 | /* Set the bus-master controller to transfer the packet. */ | 1055 | /* Set the bus-master controller to transfer the packet. */ |
@@ -1094,9 +1093,9 @@ static int corkscrew_start_xmit(struct sk_buff *skb, | |||
1094 | printk("%s: Tx error, status %2.2x.\n", | 1093 | printk("%s: Tx error, status %2.2x.\n", |
1095 | dev->name, tx_status); | 1094 | dev->name, tx_status); |
1096 | if (tx_status & 0x04) | 1095 | if (tx_status & 0x04) |
1097 | vp->stats.tx_fifo_errors++; | 1096 | dev->stats.tx_fifo_errors++; |
1098 | if (tx_status & 0x38) | 1097 | if (tx_status & 0x38) |
1099 | vp->stats.tx_aborted_errors++; | 1098 | dev->stats.tx_aborted_errors++; |
1100 | if (tx_status & 0x30) { | 1099 | if (tx_status & 0x30) { |
1101 | int j; | 1100 | int j; |
1102 | outw(TxReset, ioaddr + EL3_CMD); | 1101 | outw(TxReset, ioaddr + EL3_CMD); |
@@ -1257,7 +1256,6 @@ static irqreturn_t corkscrew_interrupt(int irq, void *dev_id) | |||
1257 | 1256 | ||
1258 | static int corkscrew_rx(struct net_device *dev) | 1257 | static int corkscrew_rx(struct net_device *dev) |
1259 | { | 1258 | { |
1260 | struct corkscrew_private *vp = netdev_priv(dev); | ||
1261 | int ioaddr = dev->base_addr; | 1259 | int ioaddr = dev->base_addr; |
1262 | int i; | 1260 | int i; |
1263 | short rx_status; | 1261 | short rx_status; |
@@ -1271,17 +1269,17 @@ static int corkscrew_rx(struct net_device *dev) | |||
1271 | if (corkscrew_debug > 2) | 1269 | if (corkscrew_debug > 2) |
1272 | printk(" Rx error: status %2.2x.\n", | 1270 | printk(" Rx error: status %2.2x.\n", |
1273 | rx_error); | 1271 | rx_error); |
1274 | vp->stats.rx_errors++; | 1272 | dev->stats.rx_errors++; |
1275 | if (rx_error & 0x01) | 1273 | if (rx_error & 0x01) |
1276 | vp->stats.rx_over_errors++; | 1274 | dev->stats.rx_over_errors++; |
1277 | if (rx_error & 0x02) | 1275 | if (rx_error & 0x02) |
1278 | vp->stats.rx_length_errors++; | 1276 | dev->stats.rx_length_errors++; |
1279 | if (rx_error & 0x04) | 1277 | if (rx_error & 0x04) |
1280 | vp->stats.rx_frame_errors++; | 1278 | dev->stats.rx_frame_errors++; |
1281 | if (rx_error & 0x08) | 1279 | if (rx_error & 0x08) |
1282 | vp->stats.rx_crc_errors++; | 1280 | dev->stats.rx_crc_errors++; |
1283 | if (rx_error & 0x10) | 1281 | if (rx_error & 0x10) |
1284 | vp->stats.rx_length_errors++; | 1282 | dev->stats.rx_length_errors++; |
1285 | } else { | 1283 | } else { |
1286 | /* The packet length: up to 4.5K!. */ | 1284 | /* The packet length: up to 4.5K!. */ |
1287 | short pkt_len = rx_status & 0x1fff; | 1285 | short pkt_len = rx_status & 0x1fff; |
@@ -1301,8 +1299,8 @@ static int corkscrew_rx(struct net_device *dev) | |||
1301 | skb->protocol = eth_type_trans(skb, dev); | 1299 | skb->protocol = eth_type_trans(skb, dev); |
1302 | netif_rx(skb); | 1300 | netif_rx(skb); |
1303 | dev->last_rx = jiffies; | 1301 | dev->last_rx = jiffies; |
1304 | vp->stats.rx_packets++; | 1302 | dev->stats.rx_packets++; |
1305 | vp->stats.rx_bytes += pkt_len; | 1303 | dev->stats.rx_bytes += pkt_len; |
1306 | /* Wait a limited time to go to next packet. */ | 1304 | /* Wait a limited time to go to next packet. */ |
1307 | for (i = 200; i >= 0; i--) | 1305 | for (i = 200; i >= 0; i--) |
1308 | if (! (inw(ioaddr + EL3_STATUS) & CmdInProgress)) | 1306 | if (! (inw(ioaddr + EL3_STATUS) & CmdInProgress)) |
@@ -1312,7 +1310,7 @@ static int corkscrew_rx(struct net_device *dev) | |||
1312 | printk("%s: Couldn't allocate a sk_buff of size %d.\n", dev->name, pkt_len); | 1310 | printk("%s: Couldn't allocate a sk_buff of size %d.\n", dev->name, pkt_len); |
1313 | } | 1311 | } |
1314 | outw(RxDiscard, ioaddr + EL3_CMD); | 1312 | outw(RxDiscard, ioaddr + EL3_CMD); |
1315 | vp->stats.rx_dropped++; | 1313 | dev->stats.rx_dropped++; |
1316 | /* Wait a limited time to skip this packet. */ | 1314 | /* Wait a limited time to skip this packet. */ |
1317 | for (i = 200; i >= 0; i--) | 1315 | for (i = 200; i >= 0; i--) |
1318 | if (!(inw(ioaddr + EL3_STATUS) & CmdInProgress)) | 1316 | if (!(inw(ioaddr + EL3_STATUS) & CmdInProgress)) |
@@ -1337,23 +1335,23 @@ static int boomerang_rx(struct net_device *dev) | |||
1337 | if (corkscrew_debug > 2) | 1335 | if (corkscrew_debug > 2) |
1338 | printk(" Rx error: status %2.2x.\n", | 1336 | printk(" Rx error: status %2.2x.\n", |
1339 | rx_error); | 1337 | rx_error); |
1340 | vp->stats.rx_errors++; | 1338 | dev->stats.rx_errors++; |
1341 | if (rx_error & 0x01) | 1339 | if (rx_error & 0x01) |
1342 | vp->stats.rx_over_errors++; | 1340 | dev->stats.rx_over_errors++; |
1343 | if (rx_error & 0x02) | 1341 | if (rx_error & 0x02) |
1344 | vp->stats.rx_length_errors++; | 1342 | dev->stats.rx_length_errors++; |
1345 | if (rx_error & 0x04) | 1343 | if (rx_error & 0x04) |
1346 | vp->stats.rx_frame_errors++; | 1344 | dev->stats.rx_frame_errors++; |
1347 | if (rx_error & 0x08) | 1345 | if (rx_error & 0x08) |
1348 | vp->stats.rx_crc_errors++; | 1346 | dev->stats.rx_crc_errors++; |
1349 | if (rx_error & 0x10) | 1347 | if (rx_error & 0x10) |
1350 | vp->stats.rx_length_errors++; | 1348 | dev->stats.rx_length_errors++; |
1351 | } else { | 1349 | } else { |
1352 | /* The packet length: up to 4.5K!. */ | 1350 | /* The packet length: up to 4.5K!. */ |
1353 | short pkt_len = rx_status & 0x1fff; | 1351 | short pkt_len = rx_status & 0x1fff; |
1354 | struct sk_buff *skb; | 1352 | struct sk_buff *skb; |
1355 | 1353 | ||
1356 | vp->stats.rx_bytes += pkt_len; | 1354 | dev->stats.rx_bytes += pkt_len; |
1357 | if (corkscrew_debug > 4) | 1355 | if (corkscrew_debug > 4) |
1358 | printk("Receiving packet size %d status %4.4x.\n", | 1356 | printk("Receiving packet size %d status %4.4x.\n", |
1359 | pkt_len, rx_status); | 1357 | pkt_len, rx_status); |
@@ -1388,7 +1386,7 @@ static int boomerang_rx(struct net_device *dev) | |||
1388 | skb->protocol = eth_type_trans(skb, dev); | 1386 | skb->protocol = eth_type_trans(skb, dev); |
1389 | netif_rx(skb); | 1387 | netif_rx(skb); |
1390 | dev->last_rx = jiffies; | 1388 | dev->last_rx = jiffies; |
1391 | vp->stats.rx_packets++; | 1389 | dev->stats.rx_packets++; |
1392 | } | 1390 | } |
1393 | entry = (++vp->cur_rx) % RX_RING_SIZE; | 1391 | entry = (++vp->cur_rx) % RX_RING_SIZE; |
1394 | } | 1392 | } |
@@ -1475,7 +1473,7 @@ static struct net_device_stats *corkscrew_get_stats(struct net_device *dev) | |||
1475 | update_stats(dev->base_addr, dev); | 1473 | update_stats(dev->base_addr, dev); |
1476 | spin_unlock_irqrestore(&vp->lock, flags); | 1474 | spin_unlock_irqrestore(&vp->lock, flags); |
1477 | } | 1475 | } |
1478 | return &vp->stats; | 1476 | return &dev->stats; |
1479 | } | 1477 | } |
1480 | 1478 | ||
1481 | /* Update statistics. | 1479 | /* Update statistics. |
@@ -1487,19 +1485,17 @@ static struct net_device_stats *corkscrew_get_stats(struct net_device *dev) | |||
1487 | */ | 1485 | */ |
1488 | static void update_stats(int ioaddr, struct net_device *dev) | 1486 | static void update_stats(int ioaddr, struct net_device *dev) |
1489 | { | 1487 | { |
1490 | struct corkscrew_private *vp = netdev_priv(dev); | ||
1491 | |||
1492 | /* Unlike the 3c5x9 we need not turn off stats updates while reading. */ | 1488 | /* Unlike the 3c5x9 we need not turn off stats updates while reading. */ |
1493 | /* Switch to the stats window, and read everything. */ | 1489 | /* Switch to the stats window, and read everything. */ |
1494 | EL3WINDOW(6); | 1490 | EL3WINDOW(6); |
1495 | vp->stats.tx_carrier_errors += inb(ioaddr + 0); | 1491 | dev->stats.tx_carrier_errors += inb(ioaddr + 0); |
1496 | vp->stats.tx_heartbeat_errors += inb(ioaddr + 1); | 1492 | dev->stats.tx_heartbeat_errors += inb(ioaddr + 1); |
1497 | /* Multiple collisions. */ inb(ioaddr + 2); | 1493 | /* Multiple collisions. */ inb(ioaddr + 2); |
1498 | vp->stats.collisions += inb(ioaddr + 3); | 1494 | dev->stats.collisions += inb(ioaddr + 3); |
1499 | vp->stats.tx_window_errors += inb(ioaddr + 4); | 1495 | dev->stats.tx_window_errors += inb(ioaddr + 4); |
1500 | vp->stats.rx_fifo_errors += inb(ioaddr + 5); | 1496 | dev->stats.rx_fifo_errors += inb(ioaddr + 5); |
1501 | vp->stats.tx_packets += inb(ioaddr + 6); | 1497 | dev->stats.tx_packets += inb(ioaddr + 6); |
1502 | vp->stats.tx_packets += (inb(ioaddr + 9) & 0x30) << 4; | 1498 | dev->stats.tx_packets += (inb(ioaddr + 9) & 0x30) << 4; |
1503 | /* Rx packets */ inb(ioaddr + 7); | 1499 | /* Rx packets */ inb(ioaddr + 7); |
1504 | /* Must read to clear */ | 1500 | /* Must read to clear */ |
1505 | /* Tx deferrals */ inb(ioaddr + 8); | 1501 | /* Tx deferrals */ inb(ioaddr + 8); |