diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2007-08-25 01:21:50 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-08-26 21:35:36 -0400 |
commit | 26722873a460703e319462afa7ebb8ed3a036c07 (patch) | |
tree | d621eb098a252a8e91d74d635d33eb30ee05aa21 | |
parent | a96fb49be3dd2031f722bf32af6ed7db965b60f7 (diff) |
[TCP]: Describe tcp_init_cwnd() thoroughly in a comment.
People often get tripped up by this function and think that
it does not implemented the prescribed algorithms from
RFC2414 and RFC3390, even though it does.
So add a comment to head off such misunderstandings in the
future.
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/tcp_input.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index f030435e0eb4..9785df37a65f 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c | |||
@@ -755,7 +755,15 @@ void tcp_update_metrics(struct sock *sk) | |||
755 | } | 755 | } |
756 | } | 756 | } |
757 | 757 | ||
758 | /* Numbers are taken from RFC2414. */ | 758 | /* Numbers are taken from RFC3390. |
759 | * | ||
760 | * John Heffner states: | ||
761 | * | ||
762 | * The RFC specifies a window of no more than 4380 bytes | ||
763 | * unless 2*MSS > 4380. Reading the pseudocode in the RFC | ||
764 | * is a bit misleading because they use a clamp at 4380 bytes | ||
765 | * rather than use a multiplier in the relevant range. | ||
766 | */ | ||
759 | __u32 tcp_init_cwnd(struct tcp_sock *tp, struct dst_entry *dst) | 767 | __u32 tcp_init_cwnd(struct tcp_sock *tp, struct dst_entry *dst) |
760 | { | 768 | { |
761 | __u32 cwnd = (dst ? dst_metric(dst, RTAX_INITCWND) : 0); | 769 | __u32 cwnd = (dst ? dst_metric(dst, RTAX_INITCWND) : 0); |