diff options
author | Steve French <sfrench@us.ibm.com> | 2006-07-16 17:33:15 -0400 |
---|---|---|
committer | Steve French <sfrench@us.ibm.com> | 2006-08-11 17:28:02 -0400 |
commit | 5da07b0208066fd3544ecf2b521fc7a2e0228ad5 (patch) | |
tree | 915422bc93ad4fde6cbacbf980b5cd4adc32b7a7 | |
parent | 14a441a2b4ee1dfc00ec822d91d9fb20f401c62f (diff) |
[CIFS] Make midState usage more consistent
Although harmless, we were sometimes treating midState like it contained
flags but they are exclusive states, and this makes that more clear.
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Steve French <sfrench@us.ibm.com>
(cherry picked from 586c057c3a68dd6ae0f3ba94fbf76798b1558074 commit)
-rw-r--r-- | fs/cifs/transport.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index d16e6032d4cf..748b0df07a73 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c | |||
@@ -448,13 +448,13 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
448 | for (;;) { | 448 | for (;;) { |
449 | curr_timeout = timeout + jiffies; | 449 | curr_timeout = timeout + jiffies; |
450 | wait_event(ses->server->response_q, | 450 | wait_event(ses->server->response_q, |
451 | (!(midQ->midState & MID_REQUEST_SUBMITTED)) || | 451 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
452 | time_after(jiffies, curr_timeout) || | 452 | time_after(jiffies, curr_timeout) || |
453 | ((ses->server->tcpStatus != CifsGood) && | 453 | ((ses->server->tcpStatus != CifsGood) && |
454 | (ses->server->tcpStatus != CifsNew))); | 454 | (ses->server->tcpStatus != CifsNew))); |
455 | 455 | ||
456 | if (time_after(jiffies, curr_timeout) && | 456 | if (time_after(jiffies, curr_timeout) && |
457 | (midQ->midState & MID_REQUEST_SUBMITTED) && | 457 | (midQ->midState == MID_REQUEST_SUBMITTED) && |
458 | ((ses->server->tcpStatus == CifsGood) || | 458 | ((ses->server->tcpStatus == CifsGood) || |
459 | (ses->server->tcpStatus == CifsNew))) { | 459 | (ses->server->tcpStatus == CifsNew))) { |
460 | 460 | ||
@@ -485,7 +485,7 @@ SendReceive2(const unsigned int xid, struct cifsSesInfo *ses, | |||
485 | } | 485 | } |
486 | } else { | 486 | } else { |
487 | wait_event(ses->server->response_q, | 487 | wait_event(ses->server->response_q, |
488 | (!(midQ->midState & MID_REQUEST_SUBMITTED)) || | 488 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
489 | ((ses->server->tcpStatus != CifsGood) && | 489 | ((ses->server->tcpStatus != CifsGood) && |
490 | (ses->server->tcpStatus != CifsNew))); | 490 | (ses->server->tcpStatus != CifsNew))); |
491 | } | 491 | } |
@@ -749,13 +749,13 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
749 | for (;;) { | 749 | for (;;) { |
750 | curr_timeout = timeout + jiffies; | 750 | curr_timeout = timeout + jiffies; |
751 | wait_event(ses->server->response_q, | 751 | wait_event(ses->server->response_q, |
752 | (!(midQ->midState & MID_REQUEST_SUBMITTED)) || | 752 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
753 | time_after(jiffies, curr_timeout) || | 753 | time_after(jiffies, curr_timeout) || |
754 | ((ses->server->tcpStatus != CifsGood) && | 754 | ((ses->server->tcpStatus != CifsGood) && |
755 | (ses->server->tcpStatus != CifsNew))); | 755 | (ses->server->tcpStatus != CifsNew))); |
756 | 756 | ||
757 | if (time_after(jiffies, curr_timeout) && | 757 | if (time_after(jiffies, curr_timeout) && |
758 | (midQ->midState & MID_REQUEST_SUBMITTED) && | 758 | (midQ->midState == MID_REQUEST_SUBMITTED) && |
759 | ((ses->server->tcpStatus == CifsGood) || | 759 | ((ses->server->tcpStatus == CifsGood) || |
760 | (ses->server->tcpStatus == CifsNew))) { | 760 | (ses->server->tcpStatus == CifsNew))) { |
761 | 761 | ||
@@ -780,7 +780,7 @@ SendReceive(const unsigned int xid, struct cifsSesInfo *ses, | |||
780 | } | 780 | } |
781 | } else { | 781 | } else { |
782 | wait_event(ses->server->response_q, | 782 | wait_event(ses->server->response_q, |
783 | (!(midQ->midState & MID_REQUEST_SUBMITTED)) || | 783 | (!(midQ->midState == MID_REQUEST_SUBMITTED)) || |
784 | ((ses->server->tcpStatus != CifsGood) && | 784 | ((ses->server->tcpStatus != CifsGood) && |
785 | (ses->server->tcpStatus != CifsNew))); | 785 | (ses->server->tcpStatus != CifsNew))); |
786 | } | 786 | } |