aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <dada1@cosmosbay.com>2009-03-21 16:42:55 -0400
committerDavid S. Miller <davem@davemloft.net>2009-03-21 16:42:55 -0400
commited734a97c6a81b644bd648afd7a337deb0ccd7e5 (patch)
tree2c030345bf9fb6ab6228d4757a96f9f7109fa60e
parent8d2f9e81169b8120cf2b4872930ae491b17c27b8 (diff)
net: remove useless prefetch() call
There is no gain using prefetch() in dev_hard_start_xmit(), since we already had to read ops->ndo_select_queue pointer in dev_pick_tx(), and both pointers are probably located in the same cache line. This prefetch call slows down fast path because of a stall in address computation. Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/dev.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index fdb9973b82a6..052dd478d3e1 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1670,7 +1670,6 @@ int dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev,
1670 const struct net_device_ops *ops = dev->netdev_ops; 1670 const struct net_device_ops *ops = dev->netdev_ops;
1671 int rc; 1671 int rc;
1672 1672
1673 prefetch(&dev->netdev_ops->ndo_start_xmit);
1674 if (likely(!skb->next)) { 1673 if (likely(!skb->next)) {
1675 if (!list_empty(&ptype_all)) 1674 if (!list_empty(&ptype_all))
1676 dev_queue_xmit_nit(skb, dev); 1675 dev_queue_xmit_nit(skb, dev);