aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBernhard Walle <bwalle@suse.de>2008-06-08 09:46:30 -0400
committerIngo Molnar <mingo@elte.hu>2008-07-08 04:34:54 -0400
commit8b2ef1d7285740953a2c4ef7faf15fdfc5e2f358 (patch)
tree4e7146ba90fdbecf49bbf6a867d1b2951d67d5c3
parent896395c290f902576270d84291c1f7f8bfbe339d (diff)
x86: add flags parameter to reserve_bootmem_generic()
This patch adds a 'flags' parameter to reserve_bootmem_generic() like it already has been added in reserve_bootmem() with commit 72a7fe3967dbf86cb34e24fbf1d957fe24d2f246. It also changes all users to use BOOTMEM_DEFAULT, which doesn't effectively change the behaviour. Since the change is x86-specific, I don't think it's necessary to add a new API for migration. There are only 4 users of that function. The change is necessary for the next patch, using reserve_bootmem_generic() for crashkernel reservation. Signed-off-by: Bernhard Walle <bwalle@suse.de> Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/kernel/mpparse.c5
-rw-r--r--arch/x86/mm/init_64.c17
-rw-r--r--include/asm-x86/proto.h2
3 files changed, 16 insertions, 8 deletions
diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index 1cc7a4b8643f..6ae60909b601 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -880,10 +880,11 @@ static int __init smp_scan_config(unsigned long base, unsigned long length,
880 if (!reserve) 880 if (!reserve)
881 return 1; 881 return 1;
882 882
883 reserve_bootmem_generic(virt_to_phys(mpf), PAGE_SIZE); 883 reserve_bootmem_generic(virt_to_phys(mpf), PAGE_SIZE,
884 BOOTMEM_DEFAULT);
884 if (mpf->mpf_physptr) 885 if (mpf->mpf_physptr)
885 reserve_bootmem_generic(mpf->mpf_physptr, 886 reserve_bootmem_generic(mpf->mpf_physptr,
886 PAGE_SIZE); 887 PAGE_SIZE, BOOTMEM_DEFAULT);
887#endif 888#endif
888 return 1; 889 return 1;
889 } 890 }
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 819dad973b13..bf7bf1de6c25 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -799,12 +799,13 @@ void free_initrd_mem(unsigned long start, unsigned long end)
799} 799}
800#endif 800#endif
801 801
802void __init reserve_bootmem_generic(unsigned long phys, unsigned len) 802int __init reserve_bootmem_generic(unsigned long phys, unsigned len, int flags)
803{ 803{
804#ifdef CONFIG_NUMA 804#ifdef CONFIG_NUMA
805 int nid, next_nid; 805 int nid, next_nid;
806#endif 806#endif
807 unsigned long pfn = phys >> PAGE_SHIFT; 807 unsigned long pfn = phys >> PAGE_SHIFT;
808 int ret;
808 809
809 if (pfn >= end_pfn) { 810 if (pfn >= end_pfn) {
810 /* 811 /*
@@ -812,11 +813,11 @@ void __init reserve_bootmem_generic(unsigned long phys, unsigned len)
812 * firmware tables: 813 * firmware tables:
813 */ 814 */
814 if (pfn < max_pfn_mapped) 815 if (pfn < max_pfn_mapped)
815 return; 816 return -EFAULT;
816 817
817 printk(KERN_ERR "reserve_bootmem: illegal reserve %lx %u\n", 818 printk(KERN_ERR "reserve_bootmem: illegal reserve %lx %u\n",
818 phys, len); 819 phys, len);
819 return; 820 return -EFAULT;
820 } 821 }
821 822
822 /* Should check here against the e820 map to avoid double free */ 823 /* Should check here against the e820 map to avoid double free */
@@ -824,9 +825,13 @@ void __init reserve_bootmem_generic(unsigned long phys, unsigned len)
824 nid = phys_to_nid(phys); 825 nid = phys_to_nid(phys);
825 next_nid = phys_to_nid(phys + len - 1); 826 next_nid = phys_to_nid(phys + len - 1);
826 if (nid == next_nid) 827 if (nid == next_nid)
827 reserve_bootmem_node(NODE_DATA(nid), phys, len, BOOTMEM_DEFAULT); 828 ret = reserve_bootmem_node(NODE_DATA(nid), phys, len, flags);
828 else 829 else
829 reserve_bootmem(phys, len, BOOTMEM_DEFAULT); 830 ret = reserve_bootmem(phys, len, flags);
831
832 if (ret != 0)
833 return ret;
834
830#else 835#else
831 reserve_bootmem(phys, len, BOOTMEM_DEFAULT); 836 reserve_bootmem(phys, len, BOOTMEM_DEFAULT);
832#endif 837#endif
@@ -835,6 +840,8 @@ void __init reserve_bootmem_generic(unsigned long phys, unsigned len)
835 dma_reserve += len / PAGE_SIZE; 840 dma_reserve += len / PAGE_SIZE;
836 set_dma_reserve(dma_reserve); 841 set_dma_reserve(dma_reserve);
837 } 842 }
843
844 return 0;
838} 845}
839 846
840int kern_addr_valid(unsigned long addr) 847int kern_addr_valid(unsigned long addr)
diff --git a/include/asm-x86/proto.h b/include/asm-x86/proto.h
index 6c8b41b03f6d..a9f51472521e 100644
--- a/include/asm-x86/proto.h
+++ b/include/asm-x86/proto.h
@@ -14,7 +14,7 @@ extern void ia32_syscall(void);
14extern void ia32_cstar_target(void); 14extern void ia32_cstar_target(void);
15extern void ia32_sysenter_target(void); 15extern void ia32_sysenter_target(void);
16 16
17extern void reserve_bootmem_generic(unsigned long phys, unsigned len); 17extern int reserve_bootmem_generic(unsigned long phys, unsigned len, int flags);
18 18
19extern void syscall32_cpu_init(void); 19extern void syscall32_cpu_init(void);
20 20