aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJarod Wilson <jwilson@redhat.com>2008-03-08 12:52:03 -0500
committerStefan Richter <stefanr@s5r6.in-berlin.de>2008-04-18 11:55:36 -0400
commitcca6097713c62eac43aef27b31e7f1553dde4f94 (patch)
tree5e712188b9a23674cc32cbd1356ea3dedb686dba
parentc9755e14a01987ada4063e8b4c50c2b6738d879e (diff)
firewire: replace more hex values with defined csr constants
Trivial change to replace more meaningless (to the untrained eye) hex values with defined CSR constants. Signed-off-by: Jarod Wilson <jwilson@redhat.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
-rw-r--r--drivers/firewire/fw-device.c2
-rw-r--r--drivers/firewire/fw-transaction.c9
2 files changed, 7 insertions, 4 deletions
diff --git a/drivers/firewire/fw-device.c b/drivers/firewire/fw-device.c
index 75365cd0008a..2d01bc1b9752 100644
--- a/drivers/firewire/fw-device.c
+++ b/drivers/firewire/fw-device.c
@@ -410,7 +410,7 @@ read_rom(struct fw_device *device, int generation, int index, u32 *data)
410 410
411 init_completion(&callback_data.done); 411 init_completion(&callback_data.done);
412 412
413 offset = 0xfffff0000400ULL + index * 4; 413 offset = (CSR_REGISTER_BASE | CSR_CONFIG_ROM) + index * 4;
414 fw_send_request(device->card, &t, TCODE_READ_QUADLET_REQUEST, 414 fw_send_request(device->card, &t, TCODE_READ_QUADLET_REQUEST,
415 device->node_id, generation, device->max_speed, 415 device->node_id, generation, device->max_speed,
416 offset, NULL, 4, complete_transaction, &callback_data); 416 offset, NULL, 4, complete_transaction, &callback_data);
diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index e6f1bda38940..47bfe761250f 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -396,7 +396,8 @@ const struct fw_address_region fw_high_memory_region =
396const struct fw_address_region fw_private_region = 396const struct fw_address_region fw_private_region =
397 { .start = 0xffffe0000000ULL, .end = 0xfffff0000000ULL, }; 397 { .start = 0xffffe0000000ULL, .end = 0xfffff0000000ULL, };
398const struct fw_address_region fw_csr_region = 398const struct fw_address_region fw_csr_region =
399 { .start = 0xfffff0000000ULL, .end = 0xfffff0000800ULL, }; 399 { .start = CSR_REGISTER_BASE,
400 .end = CSR_REGISTER_BASE | CSR_CONFIG_ROM_END, };
400const struct fw_address_region fw_unit_space_region = 401const struct fw_address_region fw_unit_space_region =
401 { .start = 0xfffff0000900ULL, .end = 0x1000000000000ULL, }; 402 { .start = 0xfffff0000900ULL, .end = 0x1000000000000ULL, };
402EXPORT_SYMBOL(fw_low_memory_region); 403EXPORT_SYMBOL(fw_low_memory_region);
@@ -747,7 +748,8 @@ fw_core_handle_response(struct fw_card *card, struct fw_packet *p)
747EXPORT_SYMBOL(fw_core_handle_response); 748EXPORT_SYMBOL(fw_core_handle_response);
748 749
749static const struct fw_address_region topology_map_region = 750static const struct fw_address_region topology_map_region =
750 { .start = 0xfffff0001000ull, .end = 0xfffff0001400ull, }; 751 { .start = CSR_REGISTER_BASE | CSR_TOPOLOGY_MAP,
752 .end = CSR_REGISTER_BASE | CSR_TOPOLOGY_MAP_END, };
751 753
752static void 754static void
753handle_topology_map(struct fw_card *card, struct fw_request *request, 755handle_topology_map(struct fw_card *card, struct fw_request *request,
@@ -785,7 +787,8 @@ static struct fw_address_handler topology_map = {
785}; 787};
786 788
787static const struct fw_address_region registers_region = 789static const struct fw_address_region registers_region =
788 { .start = 0xfffff0000000ull, .end = 0xfffff0000400ull, }; 790 { .start = CSR_REGISTER_BASE,
791 .end = CSR_REGISTER_BASE | CSR_CONFIG_ROM, };
789 792
790static void 793static void
791handle_registers(struct fw_card *card, struct fw_request *request, 794handle_registers(struct fw_card *card, struct fw_request *request,