diff options
| author | Paul Moore <paul.moore@hp.com> | 2007-12-20 03:00:45 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-12-20 03:00:45 -0500 |
| commit | 5951cab136d8b7e84696061dc2e69c402bc94f61 (patch) | |
| tree | c00828fa48d9d02f992da23619feaafef41498bb | |
| parent | f398035f2dec0a6150833b0bc105057953594edb (diff) | |
[XFRM]: Audit function arguments misordered
In several places the arguments to the xfrm_audit_start() function are
in the wrong order resulting in incorrect user information being
reported. This patch corrects this by pacing the arguments in the
correct order.
Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/xfrm/xfrm_policy.c | 4 | ||||
| -rw-r--r-- | net/xfrm/xfrm_state.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index b91b16671c1e..26b846e11bfb 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c | |||
| @@ -2162,7 +2162,7 @@ xfrm_audit_policy_add(struct xfrm_policy *xp, int result, u32 auid, u32 sid) | |||
| 2162 | 2162 | ||
| 2163 | if (audit_enabled == 0) | 2163 | if (audit_enabled == 0) |
| 2164 | return; | 2164 | return; |
| 2165 | audit_buf = xfrm_audit_start(sid, auid); | 2165 | audit_buf = xfrm_audit_start(auid, sid); |
| 2166 | if (audit_buf == NULL) | 2166 | if (audit_buf == NULL) |
| 2167 | return; | 2167 | return; |
| 2168 | audit_log_format(audit_buf, " op=SPD-add res=%u", result); | 2168 | audit_log_format(audit_buf, " op=SPD-add res=%u", result); |
| @@ -2179,7 +2179,7 @@ xfrm_audit_policy_delete(struct xfrm_policy *xp, int result, u32 auid, u32 sid) | |||
| 2179 | 2179 | ||
| 2180 | if (audit_enabled == 0) | 2180 | if (audit_enabled == 0) |
| 2181 | return; | 2181 | return; |
| 2182 | audit_buf = xfrm_audit_start(sid, auid); | 2182 | audit_buf = xfrm_audit_start(auid, sid); |
| 2183 | if (audit_buf == NULL) | 2183 | if (audit_buf == NULL) |
| 2184 | return; | 2184 | return; |
| 2185 | audit_log_format(audit_buf, " op=SPD-delete res=%u", result); | 2185 | audit_log_format(audit_buf, " op=SPD-delete res=%u", result); |
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 1af522bf12ca..ee1e69753932 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c | |||
| @@ -2033,7 +2033,7 @@ xfrm_audit_state_add(struct xfrm_state *x, int result, u32 auid, u32 sid) | |||
| 2033 | 2033 | ||
| 2034 | if (audit_enabled == 0) | 2034 | if (audit_enabled == 0) |
| 2035 | return; | 2035 | return; |
| 2036 | audit_buf = xfrm_audit_start(sid, auid); | 2036 | audit_buf = xfrm_audit_start(auid, sid); |
| 2037 | if (audit_buf == NULL) | 2037 | if (audit_buf == NULL) |
| 2038 | return; | 2038 | return; |
| 2039 | audit_log_format(audit_buf, " op=SAD-add res=%u",result); | 2039 | audit_log_format(audit_buf, " op=SAD-add res=%u",result); |
| @@ -2053,7 +2053,7 @@ xfrm_audit_state_delete(struct xfrm_state *x, int result, u32 auid, u32 sid) | |||
| 2053 | 2053 | ||
| 2054 | if (audit_enabled == 0) | 2054 | if (audit_enabled == 0) |
| 2055 | return; | 2055 | return; |
| 2056 | audit_buf = xfrm_audit_start(sid, auid); | 2056 | audit_buf = xfrm_audit_start(auid, sid); |
| 2057 | if (audit_buf == NULL) | 2057 | if (audit_buf == NULL) |
| 2058 | return; | 2058 | return; |
| 2059 | audit_log_format(audit_buf, " op=SAD-delete res=%u",result); | 2059 | audit_log_format(audit_buf, " op=SAD-delete res=%u",result); |
