aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2008-10-03 17:15:38 -0400
committerJ. Bruce Fields <bfields@citi.umich.edu>2008-10-04 17:12:27 -0400
commit2937391385807b3da9cd7a39345259caf550b032 (patch)
tree6b75733afd1c5eb9a847c72b0c745ffc24aef559
parent26a414092353590ceaa5955bcb53f863d6ea7549 (diff)
NLM: Remove unused argument from svc_addsock() function
Clean up: The svc_addsock() function no longer uses its "proto" argument, so remove it. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Cc: Neil Brown <neilb@suse.de> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
-rw-r--r--fs/nfsd/nfsctl.c2
-rw-r--r--include/linux/sunrpc/svcsock.h5
-rw-r--r--net/sunrpc/svcsock.c4
3 files changed, 3 insertions, 8 deletions
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index 862dff5247f7..97543df58242 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -614,7 +614,7 @@ static ssize_t __write_ports(struct file *file, char *buf, size_t size)
614 return -EINVAL; 614 return -EINVAL;
615 err = nfsd_create_serv(); 615 err = nfsd_create_serv();
616 if (!err) { 616 if (!err) {
617 err = svc_addsock(nfsd_serv, fd, buf, NULL); 617 err = svc_addsock(nfsd_serv, fd, buf);
618 if (err >= 0) { 618 if (err >= 0) {
619 err = lockd_up(); 619 err = lockd_up();
620 if (err < 0) 620 if (err < 0)
diff --git a/include/linux/sunrpc/svcsock.h b/include/linux/sunrpc/svcsock.h
index 8cff696dedf5..483e10380aae 100644
--- a/include/linux/sunrpc/svcsock.h
+++ b/include/linux/sunrpc/svcsock.h
@@ -39,10 +39,7 @@ int svc_send(struct svc_rqst *);
39void svc_drop(struct svc_rqst *); 39void svc_drop(struct svc_rqst *);
40void svc_sock_update_bufs(struct svc_serv *serv); 40void svc_sock_update_bufs(struct svc_serv *serv);
41int svc_sock_names(char *buf, struct svc_serv *serv, char *toclose); 41int svc_sock_names(char *buf, struct svc_serv *serv, char *toclose);
42int svc_addsock(struct svc_serv *serv, 42int svc_addsock(struct svc_serv *serv, int fd, char *name_return);
43 int fd,
44 char *name_return,
45 int *proto);
46void svc_init_xprt_sock(void); 43void svc_init_xprt_sock(void);
47void svc_cleanup_xprt_sock(void); 44void svc_cleanup_xprt_sock(void);
48 45
diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
index f91377c14951..95293f549e9c 100644
--- a/net/sunrpc/svcsock.c
+++ b/net/sunrpc/svcsock.c
@@ -1167,8 +1167,7 @@ static struct svc_sock *svc_setup_socket(struct svc_serv *serv,
1167 1167
1168int svc_addsock(struct svc_serv *serv, 1168int svc_addsock(struct svc_serv *serv,
1169 int fd, 1169 int fd,
1170 char *name_return, 1170 char *name_return)
1171 int *proto)
1172{ 1171{
1173 int err = 0; 1172 int err = 0;
1174 struct socket *so = sockfd_lookup(fd, &err); 1173 struct socket *so = sockfd_lookup(fd, &err);
@@ -1203,7 +1202,6 @@ int svc_addsock(struct svc_serv *serv,
1203 sockfd_put(so); 1202 sockfd_put(so);
1204 return err; 1203 return err;
1205 } 1204 }
1206 if (proto) *proto = so->sk->sk_protocol;
1207 return one_sock_name(name_return, svsk); 1205 return one_sock_name(name_return, svsk);
1208} 1206}
1209EXPORT_SYMBOL_GPL(svc_addsock); 1207EXPORT_SYMBOL_GPL(svc_addsock);