diff options
author | Julia Lawall <julia@diku.dk> | 2010-01-11 10:17:12 -0500 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2010-01-11 10:17:12 -0500 |
commit | 23978161f90e5a3200ad6ac9b0d534911e4cbb28 (patch) | |
tree | 39a9bbd37416cce9dc4aff6bd6d9948e56cbec0e | |
parent | 875feb63b9567442be73efbcc9a8470e376d6423 (diff) |
drivers/block/drbd/drbd_receiver.c: correct NULL test
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y;
statement S;
@@
x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) == NULL) S
|
if (
- y
+ x
== NULL)
S
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r-- | drivers/block/drbd/drbd_receiver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index a6d266ee7e2a..dbd451984e0d 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c | |||
@@ -3945,7 +3945,7 @@ static int drbd_do_auth(struct drbd_conf *mdev) | |||
3945 | } | 3945 | } |
3946 | 3946 | ||
3947 | right_response = kmalloc(resp_size, GFP_NOIO); | 3947 | right_response = kmalloc(resp_size, GFP_NOIO); |
3948 | if (response == NULL) { | 3948 | if (right_response == NULL) { |
3949 | dev_err(DEV, "kmalloc of right_response failed\n"); | 3949 | dev_err(DEV, "kmalloc of right_response failed\n"); |
3950 | rv = 0; | 3950 | rv = 0; |
3951 | goto fail; | 3951 | goto fail; |