aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarvey Harrison <harvey.harrison@gmail.com>2008-04-25 01:19:44 -0400
committerMauro Carvalho Chehab <mchehab@infradead.org>2008-04-26 08:29:57 -0400
commit0e3cbe81d52d18d83d068935512bd623a8765c12 (patch)
tree8ae455418548989625927eff79e09eaa86539bb0
parent4aef8fddb6639056ea830509ce3015c79f158011 (diff)
V4L/DVB (7746): pvrusb2: make signed one-bit bitfields unsigned
Single-bit signed bitfields can only take 0/-1 rather than 0/1 as the drivers seems to assume...add unsigned. Noticed by sparse: drivers/media/video/pvrusb2/pvrusb2-devattr.h:107:34: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:114:37: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:117:30: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:120:23: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:124:24: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:128:23: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:138:36: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:143:24: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:144:28: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:145:26: error: dubious one-bit signed bitfield drivers/media/video/pvrusb2/pvrusb2-devattr.h:146:23: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Mike Isely <isely@pobox.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--drivers/media/video/pvrusb2/pvrusb2-devattr.h22
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.h b/drivers/media/video/pvrusb2/pvrusb2-devattr.h
index c2e2b06fe2e0..d016f8b6c70b 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-devattr.h
+++ b/drivers/media/video/pvrusb2/pvrusb2-devattr.h
@@ -104,28 +104,28 @@ struct pvr2_device_desc {
104 unsigned char digital_control_scheme; 104 unsigned char digital_control_scheme;
105 105
106 /* If set, we don't bother trying to load cx23416 firmware. */ 106 /* If set, we don't bother trying to load cx23416 firmware. */
107 int flag_skip_cx23416_firmware:1; 107 unsigned int flag_skip_cx23416_firmware:1;
108 108
109 /* If set, the encoder must be healthy in order for digital mode to 109 /* If set, the encoder must be healthy in order for digital mode to
110 work (otherwise we assume that digital streaming will work even 110 work (otherwise we assume that digital streaming will work even
111 if we fail to locate firmware for the encoder). If the device 111 if we fail to locate firmware for the encoder). If the device
112 doesn't support digital streaming then this flag has no 112 doesn't support digital streaming then this flag has no
113 effect. */ 113 effect. */
114 int flag_digital_requires_cx23416:1; 114 unsigned int flag_digital_requires_cx23416:1;
115 115
116 /* Device has a hauppauge eeprom which we can interrogate. */ 116 /* Device has a hauppauge eeprom which we can interrogate. */
117 int flag_has_hauppauge_rom:1; 117 unsigned int flag_has_hauppauge_rom:1;
118 118
119 /* Device does not require a powerup command to be issued. */ 119 /* Device does not require a powerup command to be issued. */
120 int flag_no_powerup:1; 120 unsigned int flag_no_powerup:1;
121 121
122 /* Device has a cx25840 - this enables special additional logic to 122 /* Device has a cx25840 - this enables special additional logic to
123 handle it. */ 123 handle it. */
124 int flag_has_cx25840:1; 124 unsigned int flag_has_cx25840:1;
125 125
126 /* Device has a wm8775 - this enables special additional logic to 126 /* Device has a wm8775 - this enables special additional logic to
127 ensure that it is found. */ 127 ensure that it is found. */
128 int flag_has_wm8775:1; 128 unsigned int flag_has_wm8775:1;
129 129
130 /* Device has IR hardware that can be faked into looking like a 130 /* Device has IR hardware that can be faked into looking like a
131 normal Hauppauge i2c IR receiver. This is currently very 131 normal Hauppauge i2c IR receiver. This is currently very
@@ -135,15 +135,15 @@ struct pvr2_device_desc {
135 to virtualize the presence of the non-existant IR receiver chip and 135 to virtualize the presence of the non-existant IR receiver chip and
136 implement the virtual receiver in terms of appropriate FX2 136 implement the virtual receiver in terms of appropriate FX2
137 commands. */ 137 commands. */
138 int flag_has_hauppauge_custom_ir:1; 138 unsigned int flag_has_hauppauge_custom_ir:1;
139 139
140 /* These bits define which kinds of sources the device can handle. 140 /* These bits define which kinds of sources the device can handle.
141 Note: Digital tuner presence is inferred by the 141 Note: Digital tuner presence is inferred by the
142 digital_control_scheme enumeration. */ 142 digital_control_scheme enumeration. */
143 int flag_has_fmradio:1; /* Has FM radio receiver */ 143 unsigned int flag_has_fmradio:1; /* Has FM radio receiver */
144 int flag_has_analogtuner:1; /* Has analog tuner */ 144 unsigned int flag_has_analogtuner:1; /* Has analog tuner */
145 int flag_has_composite:1; /* Has composite input */ 145 unsigned int flag_has_composite:1; /* Has composite input */
146 int flag_has_svideo:1; /* Has s-video input */ 146 unsigned int flag_has_svideo:1; /* Has s-video input */
147}; 147};
148 148
149extern struct usb_device_id pvr2_device_table[]; 149extern struct usb_device_id pvr2_device_table[];