aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans-Jürgen Koch <hjk@linutronix.de>2007-09-12 15:20:43 -0400
committerMauro Carvalho Chehab <mchehab@infradead.org>2007-10-09 21:14:35 -0400
commit588005e1008f2cea61b7a1ae2a86c531e99b8c9c (patch)
tree4d84d4c0621ffa827cb5e48db634d8380203ed5f
parent39f46adef8e83653b4716369683c134e1413ad30 (diff)
V4L/DVB (6215): Bugfix for saa6588.c, add forgotten spin_lock_init()
There's a serious bug in saa6588.c, it uses a non-initialized spin_lock. Funny thing is that it works fine with bttv, but completly freezes the machine if e.g. saa7134 is loaded. Thanks to Derek Philip for reporting this bug on the rdsd-devel list. This patch adds the missing spin_lock_init(). Signed-off-by: Hans J. Koch <hjk@linutronix.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
-rw-r--r--drivers/media/video/saa6588.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/video/saa6588.c b/drivers/media/video/saa6588.c
index 92eabf88a09b..72e344a12c79 100644
--- a/drivers/media/video/saa6588.c
+++ b/drivers/media/video/saa6588.c
@@ -406,6 +406,7 @@ static int saa6588_attach(struct i2c_adapter *adap, int addr, int kind)
406 kfree(s); 406 kfree(s);
407 return -ENOMEM; 407 return -ENOMEM;
408 } 408 }
409 spin_lock_init(&s->lock);
409 s->client = client_template; 410 s->client = client_template;
410 s->block_count = 0; 411 s->block_count = 0;
411 s->wr_index = 0; 412 s->wr_index = 0;