aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Kaehlcke <matthias.kaehlcke@gmail.com>2007-07-31 04:37:24 -0400
committerDavid S. Miller <davem@davemloft.net>2007-07-31 04:37:24 -0400
commit2fa3195d72f7d0cfb4dcb2b0dfa265ed0fa5cfa3 (patch)
tree89da0b8ac2776f104d7852b27d0aaba47ab953a1
parente5071b5493b1dcfa98a6e8a75f56997f6d4a0c25 (diff)
[SPARC] Videopix Frame Grabber: Fix unreleased lock in vfc_debug()
Videopix Frame Grabber: vfc_debug() doesn't release the device lock when copy_from_user() fails Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/sbus/char/vfc_dev.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/sbus/char/vfc_dev.c b/drivers/sbus/char/vfc_dev.c
index 26b1d2a17ed2..9269f7fbd363 100644
--- a/drivers/sbus/char/vfc_dev.c
+++ b/drivers/sbus/char/vfc_dev.c
@@ -248,6 +248,7 @@ static int vfc_debug(struct vfc_dev *dev, int cmd, void __user *argp)
248 buffer,inout.len); 248 buffer,inout.len);
249 249
250 if (copy_to_user(argp,&inout,sizeof(inout))) { 250 if (copy_to_user(argp,&inout,sizeof(inout))) {
251 vfc_unlock_device(dev);
251 kfree(buffer); 252 kfree(buffer);
252 return -EFAULT; 253 return -EFAULT;
253 } 254 }