diff options
author | Andi Kleen <ak@suse.de> | 2005-11-05 11:25:53 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-11-14 22:55:13 -0500 |
commit | 1dff7f3db5f045ccbfeca5bb00b0958a78501557 (patch) | |
tree | f4bf00e22827bd586a5fa3939b660039a3c5b199 | |
parent | 6004e1b7effcbb385a6b7c790e4b8008682cf679 (diff) |
[PATCH] x86_64: Fix up outdated pfn_to_page comment
pfn_to_page really requires pfn_valid to be true now, no question.
Some people stumbled over it, but it was misleading and wrong.
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | include/asm-x86_64/mmzone.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/include/asm-x86_64/mmzone.h b/include/asm-x86_64/mmzone.h index b40c661f111e..8d48dc7e43a7 100644 --- a/include/asm-x86_64/mmzone.h +++ b/include/asm-x86_64/mmzone.h | |||
@@ -41,9 +41,7 @@ static inline __attribute__((pure)) int phys_to_nid(unsigned long addr) | |||
41 | #define pfn_to_nid(pfn) phys_to_nid((unsigned long)(pfn) << PAGE_SHIFT) | 41 | #define pfn_to_nid(pfn) phys_to_nid((unsigned long)(pfn) << PAGE_SHIFT) |
42 | #define kvaddr_to_nid(kaddr) phys_to_nid(__pa(kaddr)) | 42 | #define kvaddr_to_nid(kaddr) phys_to_nid(__pa(kaddr)) |
43 | 43 | ||
44 | /* AK: this currently doesn't deal with invalid addresses. We'll see | 44 | /* Requires pfn_valid(pfn) to be true */ |
45 | if the 2.5 kernel doesn't pass them | ||
46 | (2.4 used to). */ | ||
47 | #define pfn_to_page(pfn) ({ \ | 45 | #define pfn_to_page(pfn) ({ \ |
48 | int nid = phys_to_nid(((unsigned long)(pfn)) << PAGE_SHIFT); \ | 46 | int nid = phys_to_nid(((unsigned long)(pfn)) << PAGE_SHIFT); \ |
49 | ((pfn) - node_start_pfn(nid)) + NODE_DATA(nid)->node_mem_map; \ | 47 | ((pfn) - node_start_pfn(nid)) + NODE_DATA(nid)->node_mem_map; \ |