diff options
| author | Roland Dreier <rolandd@cisco.com> | 2007-07-17 21:37:41 -0400 |
|---|---|---|
| committer | Roland Dreier <rolandd@cisco.com> | 2007-07-17 21:37:41 -0400 |
| commit | f6be6fbe262d065e85be159ea27460852f13ec90 (patch) | |
| tree | 34ae1a7be6e0d0501b24b18dac520f249c67bab7 | |
| parent | 2b94397adc68c2f0f851539884cc426e03444a26 (diff) | |
IB/mthca: Schedule MSI support for removal
The mthca driver supports both MSI and MSI-X. However, MSI-X works with
all hardware that the driver handles, and provides a superset of what
MSI does, so there's no point in having code for both. Schedule MSI
support for removal in 2008 to give anyone who actually needs MSI and
who can't use MSI time to speak up.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
| -rw-r--r-- | Documentation/feature-removal-schedule.txt | 10 | ||||
| -rw-r--r-- | drivers/infiniband/hw/mthca/mthca_main.c | 20 |
2 files changed, 26 insertions, 4 deletions
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index d05e6243b4df..d245c639c222 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt | |||
| @@ -310,3 +310,13 @@ Why: The arch/powerpc tree is the merged architecture for ppc32 and ppc64 | |||
| 310 | Who: linuxppc-dev@ozlabs.org | 310 | Who: linuxppc-dev@ozlabs.org |
| 311 | 311 | ||
| 312 | --------------------------- | 312 | --------------------------- |
| 313 | |||
| 314 | What: mthca driver's MSI support | ||
| 315 | When: January 2008 | ||
| 316 | Files: drivers/infiniband/hw/mthca/*.[ch] | ||
| 317 | Why: All mthca hardware also supports MSI-X, which provides | ||
| 318 | strictly more functionality than MSI. So there is no point in | ||
| 319 | having both MSI-X and MSI support in the driver. | ||
| 320 | Who: Roland Dreier <rolandd@cisco.com> | ||
| 321 | |||
| 322 | --------------------------- | ||
diff --git a/drivers/infiniband/hw/mthca/mthca_main.c b/drivers/infiniband/hw/mthca/mthca_main.c index aa563e61de65..7ea6713afea8 100644 --- a/drivers/infiniband/hw/mthca/mthca_main.c +++ b/drivers/infiniband/hw/mthca/mthca_main.c | |||
| @@ -67,7 +67,7 @@ MODULE_PARM_DESC(msi_x, "attempt to use MSI-X if nonzero"); | |||
| 67 | 67 | ||
| 68 | static int msi = 0; | 68 | static int msi = 0; |
| 69 | module_param(msi, int, 0444); | 69 | module_param(msi, int, 0444); |
| 70 | MODULE_PARM_DESC(msi, "attempt to use MSI if nonzero"); | 70 | MODULE_PARM_DESC(msi, "attempt to use MSI if nonzero (deprecated, use MSI-X instead)"); |
| 71 | 71 | ||
| 72 | #else /* CONFIG_PCI_MSI */ | 72 | #else /* CONFIG_PCI_MSI */ |
| 73 | 73 | ||
| @@ -1117,9 +1117,21 @@ static int __mthca_init_one(struct pci_dev *pdev, int hca_type) | |||
| 1117 | 1117 | ||
| 1118 | if (msi_x && !mthca_enable_msi_x(mdev)) | 1118 | if (msi_x && !mthca_enable_msi_x(mdev)) |
| 1119 | mdev->mthca_flags |= MTHCA_FLAG_MSI_X; | 1119 | mdev->mthca_flags |= MTHCA_FLAG_MSI_X; |
| 1120 | if (msi && !(mdev->mthca_flags & MTHCA_FLAG_MSI_X) && | 1120 | else if (msi) { |
| 1121 | !pci_enable_msi(pdev)) | 1121 | static int warned; |
| 1122 | mdev->mthca_flags |= MTHCA_FLAG_MSI; | 1122 | |
| 1123 | if (!warned) { | ||
| 1124 | printk(KERN_WARNING PFX "WARNING: MSI support will be " | ||
| 1125 | "removed from the ib_mthca driver in January 2008.\n"); | ||
| 1126 | printk(KERN_WARNING " If you are using MSI and cannot " | ||
| 1127 | "switch to MSI-X, please tell " | ||
| 1128 | "<general@lists.openfabrics.org>.\n"); | ||
| 1129 | ++warned; | ||
| 1130 | } | ||
| 1131 | |||
| 1132 | if (!pci_enable_msi(pdev)) | ||
| 1133 | mdev->mthca_flags |= MTHCA_FLAG_MSI; | ||
| 1134 | } | ||
| 1123 | 1135 | ||
| 1124 | if (mthca_cmd_init(mdev)) { | 1136 | if (mthca_cmd_init(mdev)) { |
| 1125 | mthca_err(mdev, "Failed to init command interface, aborting.\n"); | 1137 | mthca_err(mdev, "Failed to init command interface, aborting.\n"); |