aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2008-08-25 06:30:15 -0400
committerJens Axboe <jens.axboe@oracle.com>2008-10-09 02:56:04 -0400
commitec2cdedf798385a9397ac50dd0405dd658f8529c (patch)
treecd1c44d91a2baa4a56e0ca1ce6b854beb7cb3c39
parentdef4e38ddda9bef20b69bfa939195c2f79da7979 (diff)
block: allow deleting zero length partition
delete_partition() was noop for zero length partition. As the addition code allows creating zero lenght partition and deletion is assumed to always succeed, this causes memory leak for zero length partitions. Allow zero length partitions to end their meaningless lives. While at it, allow deleting zero lenght partition via BLKPG_DEL_PARTITION ioctl too. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r--block/ioctl.c2
-rw-r--r--fs/partitions/check.c2
2 files changed, 0 insertions, 4 deletions
diff --git a/block/ioctl.c b/block/ioctl.c
index 375c57922b00..c722de0ef2ee 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -68,8 +68,6 @@ static int blkpg_ioctl(struct block_device *bdev, struct blkpg_ioctl_arg __user
68 case BLKPG_DEL_PARTITION: 68 case BLKPG_DEL_PARTITION:
69 if (!disk->part[part-1]) 69 if (!disk->part[part-1])
70 return -ENXIO; 70 return -ENXIO;
71 if (disk->part[part - 1]->nr_sects == 0)
72 return -ENXIO;
73 bdevp = bdget_disk(disk, part); 71 bdevp = bdget_disk(disk, part);
74 if (!bdevp) 72 if (!bdevp)
75 return -ENOMEM; 73 return -ENOMEM;
diff --git a/fs/partitions/check.c b/fs/partitions/check.c
index ecc3330972e5..68f3e41ae66f 100644
--- a/fs/partitions/check.c
+++ b/fs/partitions/check.c
@@ -325,8 +325,6 @@ void delete_partition(struct gendisk *disk, int part)
325 325
326 if (!p) 326 if (!p)
327 return; 327 return;
328 if (!p->nr_sects)
329 return;
330 disk->part[part-1] = NULL; 328 disk->part[part-1] = NULL;
331 p->start_sect = 0; 329 p->start_sect = 0;
332 p->nr_sects = 0; 330 p->nr_sects = 0;