aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@www.linux.org.uk>2005-06-06 16:36:01 -0400
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-06-06 17:42:24 -0400
commitd73ffe16b8baafae6e9249acee6b50c24099c6de (patch)
tree321319974be9fcc50f4ec36ccad26b84d4b66b66
parent4e7506e4dd9e40c189fcbec95d5dbc92f2e5926a (diff)
[PATCH] namei fixes (4/19)
path.mnt in open_namei() set to mirror nd->mnt. nd->mnt is set in 3 places in that function - path_lookup() in the beginning, __follow_down() loop after do_last: and __do_follow_link() call after do_link:. We set path.mnt to nd->mnt after path_lookup() and __do_follow_link(). In __follow_down() loop we use &path.mnt instead of &nd->mnt and set nd->mnt to path.mnt immediately after that loop. Obviously equivalent transformation. Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--fs/namei.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 167f19b5e51a..e42f7c35545a 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1442,6 +1442,7 @@ int open_namei(const char * pathname, int flag, int mode, struct nameidata *nd)
1442 nd->flags &= ~LOOKUP_PARENT; 1442 nd->flags &= ~LOOKUP_PARENT;
1443 down(&dir->d_inode->i_sem); 1443 down(&dir->d_inode->i_sem);
1444 path.dentry = __lookup_hash(&nd->last, nd->dentry, nd); 1444 path.dentry = __lookup_hash(&nd->last, nd->dentry, nd);
1445 path.mnt = nd->mnt;
1445 1446
1446do_last: 1447do_last:
1447 error = PTR_ERR(path.dentry); 1448 error = PTR_ERR(path.dentry);
@@ -1479,7 +1480,8 @@ do_last:
1479 error = -ELOOP; 1480 error = -ELOOP;
1480 if (flag & O_NOFOLLOW) 1481 if (flag & O_NOFOLLOW)
1481 goto exit_dput; 1482 goto exit_dput;
1482 while (__follow_down(&nd->mnt,&path.dentry) && d_mountpoint(path.dentry)); 1483 while (__follow_down(&path.mnt,&path.dentry) && d_mountpoint(path.dentry));
1484 nd->mnt = path.mnt;
1483 } 1485 }
1484 error = -ENOENT; 1486 error = -ENOENT;
1485 if (!path.dentry->d_inode) 1487 if (!path.dentry->d_inode)
@@ -1524,6 +1526,7 @@ do_link:
1524 goto exit_dput; 1526 goto exit_dput;
1525 error = __do_follow_link(path.dentry, nd); 1527 error = __do_follow_link(path.dentry, nd);
1526 dput(path.dentry); 1528 dput(path.dentry);
1529 path.mnt = nd->mnt;
1527 if (error) 1530 if (error)
1528 return error; 1531 return error;
1529 nd->flags &= ~LOOKUP_PARENT; 1532 nd->flags &= ~LOOKUP_PARENT;