diff options
author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2009-09-17 14:48:05 -0400 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2009-10-01 15:15:43 -0400 |
commit | 2e043986d584cf95656d4ee0c40fb2051e8a8460 (patch) | |
tree | 9a1cfc5fb0fd8ec639bd239e464f59298e588106 | |
parent | 39ccf9a645dbca7f9866317380912327570787c0 (diff) |
cciss: Don't check h->busy_initializing in cciss_open().
Don't check h->busy_initializing in cciss_open(). Open won't be
called before things are ready, but h->busy_initializing won't be
unset until after the initial rebuild_lun_table is finished. But,
to read the partitions, cciss_open will be called for each logical
drive during rebuild_lun_table. If cciss_open checks h->busy_initializing,
then the reading of the partition information during the initial
rebuild_lun_table will fail, which is especially bad news if it
happens to be your boot device.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
-rw-r--r-- | drivers/block/cciss.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index d6ea93767970..79afca2e824f 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
@@ -830,7 +830,7 @@ static int cciss_open(struct block_device *bdev, fmode_t mode) | |||
830 | printk(KERN_DEBUG "cciss_open %s\n", bdev->bd_disk->disk_name); | 830 | printk(KERN_DEBUG "cciss_open %s\n", bdev->bd_disk->disk_name); |
831 | #endif /* CCISS_DEBUG */ | 831 | #endif /* CCISS_DEBUG */ |
832 | 832 | ||
833 | if (host->busy_initializing || drv->busy_configuring) | 833 | if (drv->busy_configuring) |
834 | return -EBUSY; | 834 | return -EBUSY; |
835 | /* | 835 | /* |
836 | * Root is allowed to open raw volume zero even if it's not configured | 836 | * Root is allowed to open raw volume zero even if it's not configured |