diff options
author | KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> | 2009-01-07 21:08:17 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-01-08 11:31:07 -0500 |
commit | eeee9a8cd1e93c8b94e7788790fa9e2f8910c779 (patch) | |
tree | 2ef0a61a4ce12410ecfa48014a0181c03e73a3cb | |
parent | c9f299d9862deadf9fbee3ca28d915fdb006975a (diff) |
mm: make get_scan_ratio() safe for memcg
Currently, get_scan_ratio() always calculate the balancing value for
global reclaim and memcg reclaim doesn't use it. Therefore it doesn't
have scan_global_lru() condition.
However, we plan to expand get_scan_ratio() to be usable for memcg too,
latter. Then, The dependency code of global reclaim in the
get_scan_ratio() insert into scan_global_lru() condision explictly.
This patch doesn't have any functional change.
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Hugh Dickins <hugh@veritas.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/vmscan.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/mm/vmscan.c b/mm/vmscan.c index 6827d35954fb..e2b31a522a66 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c | |||
@@ -1376,13 +1376,16 @@ static void get_scan_ratio(struct zone *zone, struct scan_control *sc, | |||
1376 | zone_nr_pages(zone, sc, LRU_INACTIVE_ANON); | 1376 | zone_nr_pages(zone, sc, LRU_INACTIVE_ANON); |
1377 | file = zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) + | 1377 | file = zone_nr_pages(zone, sc, LRU_ACTIVE_FILE) + |
1378 | zone_nr_pages(zone, sc, LRU_INACTIVE_FILE); | 1378 | zone_nr_pages(zone, sc, LRU_INACTIVE_FILE); |
1379 | free = zone_page_state(zone, NR_FREE_PAGES); | ||
1380 | 1379 | ||
1381 | /* If we have very few page cache pages, force-scan anon pages. */ | 1380 | if (scan_global_lru(sc)) { |
1382 | if (unlikely(file + free <= zone->pages_high)) { | 1381 | free = zone_page_state(zone, NR_FREE_PAGES); |
1383 | percent[0] = 100; | 1382 | /* If we have very few page cache pages, |
1384 | percent[1] = 0; | 1383 | force-scan anon pages. */ |
1385 | return; | 1384 | if (unlikely(file + free <= zone->pages_high)) { |
1385 | percent[0] = 100; | ||
1386 | percent[1] = 0; | ||
1387 | return; | ||
1388 | } | ||
1386 | } | 1389 | } |
1387 | 1390 | ||
1388 | /* | 1391 | /* |