diff options
author | Jody McIntyre <scjdy@steamballoon.com> | 2005-11-22 12:17:14 -0500 |
---|---|---|
committer | Jody McIntyre <scjody@modernduck.com> | 2005-11-22 12:17:14 -0500 |
commit | a96074e76f87a4f658af4ecfd95edc89cfd61fc1 (patch) | |
tree | 5c791716a5b8533f25025fbd019d72b9f4e9907f | |
parent | 5303a986c33ae6c75d5ffb57d06ccf9246a8725a (diff) |
csr1212: add check for !valid
Don't read the keyval if there's already a valid one in place. May not be
necessary but shouldn't hurt.
Signed-off-by: Jody McIntyre <scjdy@steamballoon.com>
-rw-r--r-- | drivers/ieee1394/csr1212.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/ieee1394/csr1212.c b/drivers/ieee1394/csr1212.c index 4812d59e8976..15773544234b 100644 --- a/drivers/ieee1394/csr1212.c +++ b/drivers/ieee1394/csr1212.c | |||
@@ -1618,7 +1618,8 @@ int csr1212_parse_csr(struct csr1212_csr *csr) | |||
1618 | * and make cache regions for them */ | 1618 | * and make cache regions for them */ |
1619 | for (dentry = csr->root_kv->value.directory.dentries_head; | 1619 | for (dentry = csr->root_kv->value.directory.dentries_head; |
1620 | dentry; dentry = dentry->next) { | 1620 | dentry; dentry = dentry->next) { |
1621 | if (dentry->kv->key.id == CSR1212_KV_ID_EXTENDED_ROM) { | 1621 | if (dentry->kv->key.id == CSR1212_KV_ID_EXTENDED_ROM && |
1622 | !dentry->kv->valid) { | ||
1622 | ret = _csr1212_read_keyval(csr, dentry->kv); | 1623 | ret = _csr1212_read_keyval(csr, dentry->kv); |
1623 | if (ret != CSR1212_SUCCESS) | 1624 | if (ret != CSR1212_SUCCESS) |
1624 | return ret; | 1625 | return ret; |