aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeff Garzik <jeff@garzik.org>2007-10-19 02:54:26 -0400
committerJeff Garzik <jeff@garzik.org>2007-10-23 19:53:16 -0400
commit5712cb3d81566893c3b14e24075cf48ec5c35d00 (patch)
tree8258fb24a0c5130e8c0cad16d2d9395941be3ed7
parentf230d1010ad0dcd71d9ca8ea6864afac49c5aa9b (diff)
[PARPORT] Remove unused 'irq' argument from parport irq functions
None of the drivers with a struct pardevice's ->irq_func() hook ever used the 'irq' argument passed to it, so remove it. Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
-rw-r--r--drivers/char/ppdev.c4
-rw-r--r--drivers/input/serio/parkbd.c2
-rw-r--r--drivers/net/hamradio/baycom_epp.c8
-rw-r--r--drivers/net/hamradio/baycom_par.c4
-rw-r--r--drivers/net/plip.c6
-rw-r--r--drivers/parport/daisy.c13
-rw-r--r--drivers/parport/probe.c3
-rw-r--r--drivers/parport/share.c2
-rw-r--r--include/linux/parport.h12
-rw-r--r--sound/drivers/mts64.c2
-rw-r--r--sound/drivers/portman2x4.c2
11 files changed, 19 insertions, 39 deletions
diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
index efe2f5c55b91..3aab837d9480 100644
--- a/drivers/char/ppdev.c
+++ b/drivers/char/ppdev.c
@@ -267,9 +267,9 @@ static ssize_t pp_write (struct file * file, const char __user * buf,
267 return bytes_written; 267 return bytes_written;
268} 268}
269 269
270static void pp_irq (int irq, void * private) 270static void pp_irq (void *private)
271{ 271{
272 struct pp_struct * pp = (struct pp_struct *) private; 272 struct pp_struct *pp = private;
273 273
274 if (pp->irqresponse) { 274 if (pp->irqresponse) {
275 parport_write_control (pp->pdev->port, pp->irqctl); 275 parport_write_control (pp->pdev->port, pp->irqctl);
diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c
index 688610e86a3e..b089977e0ef9 100644
--- a/drivers/input/serio/parkbd.c
+++ b/drivers/input/serio/parkbd.c
@@ -102,7 +102,7 @@ static int parkbd_write(struct serio *port, unsigned char c)
102 return 0; 102 return 0;
103} 103}
104 104
105static void parkbd_interrupt(int irq, void *dev_id) 105static void parkbd_interrupt(void *dev_id)
106{ 106{
107 107
108 if (parkbd_writing) { 108 if (parkbd_writing) {
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 1a5a75acf73e..dde9c7e6408a 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -325,12 +325,6 @@ static int eppconfig(struct baycom_state *bc)
325 325
326/* ---------------------------------------------------------------------- */ 326/* ---------------------------------------------------------------------- */
327 327
328static void epp_interrupt(int irq, void *dev_id)
329{
330}
331
332/* ---------------------------------------------------------------------- */
333
334static inline void do_kiss_params(struct baycom_state *bc, 328static inline void do_kiss_params(struct baycom_state *bc,
335 unsigned char *data, unsigned long len) 329 unsigned char *data, unsigned long len)
336{ 330{
@@ -871,7 +865,7 @@ static int epp_open(struct net_device *dev)
871 } 865 }
872 memset(&bc->modem, 0, sizeof(bc->modem)); 866 memset(&bc->modem, 0, sizeof(bc->modem));
873 bc->pdev = parport_register_device(pp, dev->name, NULL, epp_wakeup, 867 bc->pdev = parport_register_device(pp, dev->name, NULL, epp_wakeup,
874 epp_interrupt, PARPORT_DEV_EXCL, dev); 868 NULL, PARPORT_DEV_EXCL, dev);
875 parport_put_port(pp); 869 parport_put_port(pp);
876 if (!bc->pdev) { 870 if (!bc->pdev) {
877 printk(KERN_ERR "%s: cannot register parport at 0x%lx\n", bc_drvname, pp->base); 871 printk(KERN_ERR "%s: cannot register parport at 0x%lx\n", bc_drvname, pp->base);
diff --git a/drivers/net/hamradio/baycom_par.c b/drivers/net/hamradio/baycom_par.c
index 5930aeb35015..2e6fc4dc74b1 100644
--- a/drivers/net/hamradio/baycom_par.c
+++ b/drivers/net/hamradio/baycom_par.c
@@ -270,9 +270,9 @@ static __inline__ void par96_rx(struct net_device *dev, struct baycom_state *bc)
270 270
271/* --------------------------------------------------------------------- */ 271/* --------------------------------------------------------------------- */
272 272
273static void par96_interrupt(int irq, void *dev_id) 273static void par96_interrupt(void *dev_id)
274{ 274{
275 struct net_device *dev = (struct net_device *)dev_id; 275 struct net_device *dev = dev_id;
276 struct baycom_state *bc = netdev_priv(dev); 276 struct baycom_state *bc = netdev_priv(dev);
277 277
278 baycom_int_freq(bc); 278 baycom_int_freq(bc);
diff --git a/drivers/net/plip.c b/drivers/net/plip.c
index b5e9981d1060..5071fcd8a0bd 100644
--- a/drivers/net/plip.c
+++ b/drivers/net/plip.c
@@ -143,7 +143,7 @@ static void plip_bh(struct work_struct *work);
143static void plip_timer_bh(struct work_struct *work); 143static void plip_timer_bh(struct work_struct *work);
144 144
145/* Interrupt handler */ 145/* Interrupt handler */
146static void plip_interrupt(int irq, void *dev_id); 146static void plip_interrupt(void *dev_id);
147 147
148/* Functions for DEV methods */ 148/* Functions for DEV methods */
149static int plip_tx_packet(struct sk_buff *skb, struct net_device *dev); 149static int plip_tx_packet(struct sk_buff *skb, struct net_device *dev);
@@ -380,7 +380,7 @@ plip_timer_bh(struct work_struct *work)
380 container_of(work, struct net_local, timer.work); 380 container_of(work, struct net_local, timer.work);
381 381
382 if (!(atomic_read (&nl->kill_timer))) { 382 if (!(atomic_read (&nl->kill_timer))) {
383 plip_interrupt (-1, nl->dev); 383 plip_interrupt (nl->dev);
384 384
385 schedule_delayed_work(&nl->timer, 1); 385 schedule_delayed_work(&nl->timer, 1);
386 } 386 }
@@ -897,7 +897,7 @@ plip_error(struct net_device *dev, struct net_local *nl,
897 897
898/* Handle the parallel port interrupts. */ 898/* Handle the parallel port interrupts. */
899static void 899static void
900plip_interrupt(int irq, void *dev_id) 900plip_interrupt(void *dev_id)
901{ 901{
902 struct net_device *dev = dev_id; 902 struct net_device *dev = dev_id;
903 struct net_local *nl; 903 struct net_local *nl;
diff --git a/drivers/parport/daisy.c b/drivers/parport/daisy.c
index 5bbff2028f8f..3c8f06c3a5a0 100644
--- a/drivers/parport/daisy.c
+++ b/drivers/parport/daisy.c
@@ -199,11 +199,6 @@ void parport_daisy_fini(struct parport *port)
199 * parport_open - find a device by canonical device number 199 * parport_open - find a device by canonical device number
200 * @devnum: canonical device number 200 * @devnum: canonical device number
201 * @name: name to associate with the device 201 * @name: name to associate with the device
202 * @pf: preemption callback
203 * @kf: kick callback
204 * @irqf: interrupt handler
205 * @flags: registration flags
206 * @handle: driver data
207 * 202 *
208 * This function is similar to parport_register_device(), except 203 * This function is similar to parport_register_device(), except
209 * that it locates a device by its number rather than by the port 204 * that it locates a device by its number rather than by the port
@@ -214,10 +209,7 @@ void parport_daisy_fini(struct parport *port)
214 * for parport_register_device(). 209 * for parport_register_device().
215 **/ 210 **/
216 211
217struct pardevice *parport_open(int devnum, const char *name, 212struct pardevice *parport_open(int devnum, const char *name)
218 int (*pf) (void *), void (*kf) (void *),
219 void (*irqf) (int, void *),
220 int flags, void *handle)
221{ 213{
222 struct daisydev *p = topology; 214 struct daisydev *p = topology;
223 struct parport *port; 215 struct parport *port;
@@ -237,8 +229,7 @@ struct pardevice *parport_open(int devnum, const char *name,
237 port = parport_get_port(p->port); 229 port = parport_get_port(p->port);
238 spin_unlock(&topology_lock); 230 spin_unlock(&topology_lock);
239 231
240 dev = parport_register_device(port, name, pf, kf, 232 dev = parport_register_device(port, name, NULL, NULL, NULL, 0, NULL);
241 irqf, flags, handle);
242 parport_put_port(port); 233 parport_put_port(port);
243 if (!dev) 234 if (!dev)
244 return NULL; 235 return NULL;
diff --git a/drivers/parport/probe.c b/drivers/parport/probe.c
index ea83b70e0de2..853a15f44f88 100644
--- a/drivers/parport/probe.c
+++ b/drivers/parport/probe.c
@@ -255,8 +255,7 @@ static ssize_t parport_read_device_id (struct parport *port, char *buffer,
255ssize_t parport_device_id (int devnum, char *buffer, size_t count) 255ssize_t parport_device_id (int devnum, char *buffer, size_t count)
256{ 256{
257 ssize_t retval = -ENXIO; 257 ssize_t retval = -ENXIO;
258 struct pardevice *dev = parport_open (devnum, "Device ID probe", 258 struct pardevice *dev = parport_open (devnum, "Device ID probe");
259 NULL, NULL, NULL, 0, NULL);
260 if (!dev) 259 if (!dev)
261 return -ENXIO; 260 return -ENXIO;
262 261
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index d0b353cf14ac..a8a62bbbb576 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -524,7 +524,7 @@ void parport_remove_port(struct parport *port)
524struct pardevice * 524struct pardevice *
525parport_register_device(struct parport *port, const char *name, 525parport_register_device(struct parport *port, const char *name,
526 int (*pf)(void *), void (*kf)(void *), 526 int (*pf)(void *), void (*kf)(void *),
527 void (*irq_func)(int, void *), 527 void (*irq_func)(void *),
528 int flags, void *handle) 528 int flags, void *handle)
529{ 529{
530 struct pardevice *tmp; 530 struct pardevice *tmp;
diff --git a/include/linux/parport.h b/include/linux/parport.h
index 557c37de1f38..d1ad546c8c9e 100644
--- a/include/linux/parport.h
+++ b/include/linux/parport.h
@@ -230,7 +230,7 @@ struct pardevice {
230 int (*preempt)(void *); 230 int (*preempt)(void *);
231 void (*wakeup)(void *); 231 void (*wakeup)(void *);
232 void *private; 232 void *private;
233 void (*irq_func)(int, void *); 233 void (*irq_func)(void *);
234 unsigned int flags; 234 unsigned int flags;
235 struct pardevice *next; 235 struct pardevice *next;
236 struct pardevice *prev; 236 struct pardevice *prev;
@@ -383,7 +383,7 @@ extern void parport_put_port (struct parport *);
383struct pardevice *parport_register_device(struct parport *port, 383struct pardevice *parport_register_device(struct parport *port,
384 const char *name, 384 const char *name,
385 int (*pf)(void *), void (*kf)(void *), 385 int (*pf)(void *), void (*kf)(void *),
386 void (*irq_func)(int, void *), 386 void (*irq_func)(void *),
387 int flags, void *handle); 387 int flags, void *handle);
388 388
389/* parport_unregister unlinks a device from the chain. */ 389/* parport_unregister unlinks a device from the chain. */
@@ -507,11 +507,7 @@ extern size_t parport_ieee1284_epp_read_addr (struct parport *,
507/* IEEE1284.3 functions */ 507/* IEEE1284.3 functions */
508extern int parport_daisy_init (struct parport *port); 508extern int parport_daisy_init (struct parport *port);
509extern void parport_daisy_fini (struct parport *port); 509extern void parport_daisy_fini (struct parport *port);
510extern struct pardevice *parport_open (int devnum, const char *name, 510extern struct pardevice *parport_open (int devnum, const char *name);
511 int (*pf) (void *),
512 void (*kf) (void *),
513 void (*irqf) (int, void *),
514 int flags, void *handle);
515extern void parport_close (struct pardevice *dev); 511extern void parport_close (struct pardevice *dev);
516extern ssize_t parport_device_id (int devnum, char *buffer, size_t len); 512extern ssize_t parport_device_id (int devnum, char *buffer, size_t len);
517extern void parport_daisy_deselect_all (struct parport *port); 513extern void parport_daisy_deselect_all (struct parport *port);
@@ -523,7 +519,7 @@ static inline void parport_generic_irq(struct parport *port)
523 parport_ieee1284_interrupt (port); 519 parport_ieee1284_interrupt (port);
524 read_lock(&port->cad_lock); 520 read_lock(&port->cad_lock);
525 if (port->cad && port->cad->irq_func) 521 if (port->cad && port->cad->irq_func)
526 port->cad->irq_func(port->irq, port->cad->private); 522 port->cad->irq_func(port->cad->private);
527 read_unlock(&port->cad_lock); 523 read_unlock(&port->cad_lock);
528} 524}
529 525
diff --git a/sound/drivers/mts64.c b/sound/drivers/mts64.c
index 911c159bb3d3..dcc90f995294 100644
--- a/sound/drivers/mts64.c
+++ b/sound/drivers/mts64.c
@@ -830,7 +830,7 @@ static int __devinit snd_mts64_rawmidi_create(struct snd_card *card)
830/********************************************************************* 830/*********************************************************************
831 * parport stuff 831 * parport stuff
832 *********************************************************************/ 832 *********************************************************************/
833static void snd_mts64_interrupt(int irq, void *private) 833static void snd_mts64_interrupt(void *private)
834{ 834{
835 struct mts64 *mts = ((struct snd_card*)private)->private_data; 835 struct mts64 *mts = ((struct snd_card*)private)->private_data;
836 u16 ret; 836 u16 ret;
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index 0eb9b5cebfcd..e065b2a6444a 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -611,7 +611,7 @@ static int __devinit snd_portman_rawmidi_create(struct snd_card *card)
611/********************************************************************* 611/*********************************************************************
612 * parport stuff 612 * parport stuff
613 *********************************************************************/ 613 *********************************************************************/
614static void snd_portman_interrupt(int irq, void *userdata) 614static void snd_portman_interrupt(void *userdata)
615{ 615{
616 unsigned char midivalue = 0; 616 unsigned char midivalue = 0;
617 struct portman *pm = ((struct snd_card*)userdata)->private_data; 617 struct portman *pm = ((struct snd_card*)userdata)->private_data;