diff options
author | Jean Delvare <khali@linux-fr.org> | 2005-07-19 18:05:33 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-05 12:14:12 -0400 |
commit | 02ff982c6911de1484e13a1d765d7bd31a0f8fee (patch) | |
tree | 94e8c388df0de6561da7f10840f4e87dead18724 | |
parent | 5071860aba7fc69279ab822638ed2c2e4549f9fd (diff) |
[PATCH] I2C: Separate non-i2c hwmon drivers from i2c-core (8/9)
Kill all uses of i2c_is_isa_adapter except for the hybrid drivers (it87,
lm78, w83781d). The i2c-isa adapter not being registered with the i2c
core anymore, drivers don't have to fear being erroneously attached to
it.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | Documentation/i2c/writing-clients | 11 | ||||
-rw-r--r-- | drivers/hwmon/adm1021.c | 9 | ||||
-rw-r--r-- | drivers/hwmon/asb100.c | 8 | ||||
-rw-r--r-- | drivers/hwmon/lm75.c | 10 | ||||
-rw-r--r-- | drivers/hwmon/lm85.c | 5 |
5 files changed, 5 insertions, 38 deletions
diff --git a/Documentation/i2c/writing-clients b/Documentation/i2c/writing-clients index e6b546dd4f7b..522ae01d2e7f 100644 --- a/Documentation/i2c/writing-clients +++ b/Documentation/i2c/writing-clients | |||
@@ -315,11 +315,10 @@ For now, you can ignore the `flags' parameter. It is there for future use. | |||
315 | const char *type_name = ""; | 315 | const char *type_name = ""; |
316 | int is_isa = i2c_is_isa_adapter(adapter); | 316 | int is_isa = i2c_is_isa_adapter(adapter); |
317 | 317 | ||
318 | if (is_isa) { | 318 | /* Do this only if the chip can additionally be found on the ISA bus |
319 | (hybrid chip). */ | ||
319 | 320 | ||
320 | /* If this client can't be on the ISA bus at all, we can stop now | 321 | if (is_isa) { |
321 | (call `goto ERROR0'). But for kicks, we will assume it is all | ||
322 | right. */ | ||
323 | 322 | ||
324 | /* Discard immediately if this ISA range is already used */ | 323 | /* Discard immediately if this ISA range is already used */ |
325 | if (check_region(address,FOO_EXTENT)) | 324 | if (check_region(address,FOO_EXTENT)) |
@@ -495,10 +494,10 @@ much simpler than the attachment code, fortunately! | |||
495 | return err; | 494 | return err; |
496 | } | 495 | } |
497 | 496 | ||
498 | /* SENSORS ONLY START */ | 497 | /* HYBRID SENSORS CHIP ONLY START */ |
499 | if i2c_is_isa_client(client) | 498 | if i2c_is_isa_client(client) |
500 | release_region(client->addr,LM78_EXTENT); | 499 | release_region(client->addr,LM78_EXTENT); |
501 | /* SENSORS ONLY END */ | 500 | /* HYBRID SENSORS CHIP ONLY END */ |
502 | 501 | ||
503 | kfree(client); /* Frees client data too, if allocated at the same time */ | 502 | kfree(client); /* Frees client data too, if allocated at the same time */ |
504 | return 0; | 503 | return 0; |
diff --git a/drivers/hwmon/adm1021.c b/drivers/hwmon/adm1021.c index 093d09cc4c14..2a341390d92e 100644 --- a/drivers/hwmon/adm1021.c +++ b/drivers/hwmon/adm1021.c | |||
@@ -198,15 +198,6 @@ static int adm1021_detect(struct i2c_adapter *adapter, int address, int kind) | |||
198 | int err = 0; | 198 | int err = 0; |
199 | const char *type_name = ""; | 199 | const char *type_name = ""; |
200 | 200 | ||
201 | /* Make sure we aren't probing the ISA bus!! This is just a safety check | ||
202 | at this moment; i2c_detect really won't call us. */ | ||
203 | #ifdef DEBUG | ||
204 | if (i2c_is_isa_adapter(adapter)) { | ||
205 | dev_dbg(&adapter->dev, "adm1021_detect called for an ISA bus adapter?!?\n"); | ||
206 | return 0; | ||
207 | } | ||
208 | #endif | ||
209 | |||
210 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) | 201 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) |
211 | goto error0; | 202 | goto error0; |
212 | 203 | ||
diff --git a/drivers/hwmon/asb100.c b/drivers/hwmon/asb100.c index d1856acf87a0..290f7d2ac0a8 100644 --- a/drivers/hwmon/asb100.c +++ b/drivers/hwmon/asb100.c | |||
@@ -714,14 +714,6 @@ static int asb100_detect(struct i2c_adapter *adapter, int address, int kind) | |||
714 | struct i2c_client *new_client; | 714 | struct i2c_client *new_client; |
715 | struct asb100_data *data; | 715 | struct asb100_data *data; |
716 | 716 | ||
717 | /* asb100 is SMBus only */ | ||
718 | if (i2c_is_isa_adapter(adapter)) { | ||
719 | pr_debug("asb100.o: detect failed, " | ||
720 | "cannot attach to legacy adapter!\n"); | ||
721 | err = -ENODEV; | ||
722 | goto ERROR0; | ||
723 | } | ||
724 | |||
725 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) { | 717 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) { |
726 | pr_debug("asb100.o: detect failed, " | 718 | pr_debug("asb100.o: detect failed, " |
727 | "smbus byte data not supported!\n"); | 719 | "smbus byte data not supported!\n"); |
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c index 54dda7d11ace..a2bebb6b37a6 100644 --- a/drivers/hwmon/lm75.c +++ b/drivers/hwmon/lm75.c | |||
@@ -121,16 +121,6 @@ static int lm75_detect(struct i2c_adapter *adapter, int address, int kind) | |||
121 | int err = 0; | 121 | int err = 0; |
122 | const char *name = ""; | 122 | const char *name = ""; |
123 | 123 | ||
124 | /* Make sure we aren't probing the ISA bus!! This is just a safety check | ||
125 | at this moment; i2c_detect really won't call us. */ | ||
126 | #ifdef DEBUG | ||
127 | if (i2c_is_isa_adapter(adapter)) { | ||
128 | dev_dbg(&adapter->dev, | ||
129 | "lm75_detect called for an ISA bus adapter?!?\n"); | ||
130 | goto exit; | ||
131 | } | ||
132 | #endif | ||
133 | |||
134 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | | 124 | if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA | |
135 | I2C_FUNC_SMBUS_WORD_DATA)) | 125 | I2C_FUNC_SMBUS_WORD_DATA)) |
136 | goto exit; | 126 | goto exit; |
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c index 8954d64614ff..5f051c023236 100644 --- a/drivers/hwmon/lm85.c +++ b/drivers/hwmon/lm85.c | |||
@@ -1033,11 +1033,6 @@ int lm85_detect(struct i2c_adapter *adapter, int address, | |||
1033 | int err = 0; | 1033 | int err = 0; |
1034 | const char *type_name = ""; | 1034 | const char *type_name = ""; |
1035 | 1035 | ||
1036 | if (i2c_is_isa_adapter(adapter)) { | ||
1037 | /* This chip has no ISA interface */ | ||
1038 | goto ERROR0 ; | ||
1039 | }; | ||
1040 | |||
1041 | if (!i2c_check_functionality(adapter, | 1036 | if (!i2c_check_functionality(adapter, |
1042 | I2C_FUNC_SMBUS_BYTE_DATA)) { | 1037 | I2C_FUNC_SMBUS_BYTE_DATA)) { |
1043 | /* We need to be able to do byte I/O */ | 1038 | /* We need to be able to do byte I/O */ |