diff options
author | Matthew Wilcox <matthew@wil.cx> | 2007-07-29 19:27:20 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.localdomain> | 2007-10-12 14:38:44 -0400 |
commit | 605fe5987f728e92e75ba12f7be01ffc3b132ad0 (patch) | |
tree | f2ec47698bfb5df51516db41db33923c1383d33f | |
parent | 074c8fe4c0c0c7918d99bca34ea8e02a86997530 (diff) |
[SCSI] advansys: Stop checking the scsi_cmnd belongs to our Scsi_Host
The interrupt routines used to walk the list of Scsi_Hosts belonging to
this driver to make sure that the scsi_cmnd belonged to one of them.
This is a waste of time and gets in the way of later cleanups, so
delete it.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r-- | drivers/scsi/advansys.c | 38 |
1 files changed, 0 insertions, 38 deletions
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index a407ff34199d..7a964bb75acb 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c | |||
@@ -5506,7 +5506,6 @@ static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep) | |||
5506 | asc_board_t *boardp; | 5506 | asc_board_t *boardp; |
5507 | struct scsi_cmnd *scp; | 5507 | struct scsi_cmnd *scp; |
5508 | struct Scsi_Host *shost; | 5508 | struct Scsi_Host *shost; |
5509 | int i; | ||
5510 | 5509 | ||
5511 | ASC_DBG2(1, "asc_isr_callback: asc_dvc_varp 0x%lx, qdonep 0x%lx\n", | 5510 | ASC_DBG2(1, "asc_isr_callback: asc_dvc_varp 0x%lx, qdonep 0x%lx\n", |
5512 | (ulong)asc_dvc_varp, (ulong)qdonep); | 5511 | (ulong)asc_dvc_varp, (ulong)qdonep); |
@@ -5525,23 +5524,7 @@ static void asc_isr_callback(ASC_DVC_VAR *asc_dvc_varp, ASC_QDONE_INFO *qdonep) | |||
5525 | } | 5524 | } |
5526 | ASC_DBG_PRT_CDB(2, scp->cmnd, scp->cmd_len); | 5525 | ASC_DBG_PRT_CDB(2, scp->cmnd, scp->cmd_len); |
5527 | 5526 | ||
5528 | /* | ||
5529 | * If the request's host pointer is not valid, display a | ||
5530 | * message and return. | ||
5531 | */ | ||
5532 | shost = scp->device->host; | 5527 | shost = scp->device->host; |
5533 | for (i = 0; i < asc_board_count; i++) { | ||
5534 | if (asc_host[i] == shost) { | ||
5535 | break; | ||
5536 | } | ||
5537 | } | ||
5538 | if (i == asc_board_count) { | ||
5539 | ASC_PRINT2 | ||
5540 | ("asc_isr_callback: scp 0x%lx has bad host pointer, host 0x%lx\n", | ||
5541 | (ulong)scp, (ulong)shost); | ||
5542 | return; | ||
5543 | } | ||
5544 | |||
5545 | ASC_STATS(shost, callback); | 5528 | ASC_STATS(shost, callback); |
5546 | ASC_DBG1(1, "asc_isr_callback: shost 0x%lx\n", (ulong)shost); | 5529 | ASC_DBG1(1, "asc_isr_callback: shost 0x%lx\n", (ulong)shost); |
5547 | 5530 | ||
@@ -5680,7 +5663,6 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp) | |||
5680 | adv_sgblk_t *sgblkp; | 5663 | adv_sgblk_t *sgblkp; |
5681 | struct scsi_cmnd *scp; | 5664 | struct scsi_cmnd *scp; |
5682 | struct Scsi_Host *shost; | 5665 | struct Scsi_Host *shost; |
5683 | int i; | ||
5684 | ADV_DCNT resid_cnt; | 5666 | ADV_DCNT resid_cnt; |
5685 | 5667 | ||
5686 | ASC_DBG2(1, "adv_isr_callback: adv_dvc_varp 0x%lx, scsiqp 0x%lx\n", | 5668 | ASC_DBG2(1, "adv_isr_callback: adv_dvc_varp 0x%lx, scsiqp 0x%lx\n", |
@@ -5716,27 +5698,7 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q *scsiqp) | |||
5716 | } | 5698 | } |
5717 | ASC_DBG_PRT_CDB(2, scp->cmnd, scp->cmd_len); | 5699 | ASC_DBG_PRT_CDB(2, scp->cmnd, scp->cmd_len); |
5718 | 5700 | ||
5719 | /* | ||
5720 | * If the request's host pointer is not valid, display a message | ||
5721 | * and return. | ||
5722 | */ | ||
5723 | shost = scp->device->host; | 5701 | shost = scp->device->host; |
5724 | for (i = 0; i < asc_board_count; i++) { | ||
5725 | if (asc_host[i] == shost) { | ||
5726 | break; | ||
5727 | } | ||
5728 | } | ||
5729 | /* | ||
5730 | * Note: If the host structure is not found, the adv_req_t request | ||
5731 | * structure and adv_sgblk_t structure, if any, is dropped. | ||
5732 | */ | ||
5733 | if (i == asc_board_count) { | ||
5734 | ASC_PRINT2 | ||
5735 | ("adv_isr_callback: scp 0x%lx has bad host pointer, host 0x%lx\n", | ||
5736 | (ulong)scp, (ulong)shost); | ||
5737 | return; | ||
5738 | } | ||
5739 | |||
5740 | ASC_STATS(shost, callback); | 5702 | ASC_STATS(shost, callback); |
5741 | ASC_DBG1(1, "adv_isr_callback: shost 0x%lx\n", (ulong)shost); | 5703 | ASC_DBG1(1, "adv_isr_callback: shost 0x%lx\n", (ulong)shost); |
5742 | 5704 | ||