diff options
| author | matthieu castet <castet.matthieu@free.fr> | 2006-01-18 01:39:27 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2006-01-31 20:23:41 -0500 |
| commit | fdf290fd6d6a17b40055359263ed6003e87cb89b (patch) | |
| tree | 52d27ebf44609f4d4083596919f3e11395fb5e40 | |
| parent | e40abaf6336ef3756277bab70db47a47da4aa325 (diff) | |
[PATCH] UEAGLE : cmv name bug (was cosmetic)
this patch correct a possible bug with cmv_name being static. If there
is 2 modems and the driver is scheduled when filling cmv_name this could
result with garbage in cmv_name. We allocate cmv_name on the stack but
with a small size in order to avoid that.
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/atm/ueagle-atm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index b0026ecc6a36..830d2c982670 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c | |||
| @@ -1013,7 +1013,7 @@ static int request_cmvs(struct uea_softc *sc, | |||
| 1013 | int ret, size; | 1013 | int ret, size; |
| 1014 | u8 *data; | 1014 | u8 *data; |
| 1015 | char *file; | 1015 | char *file; |
| 1016 | static char cmv_name[256] = FW_DIR; | 1016 | char cmv_name[FIRMWARE_NAME_MAX]; /* 30 bytes stack variable */ |
| 1017 | 1017 | ||
| 1018 | if (cmv_file[sc->modem_index] == NULL) { | 1018 | if (cmv_file[sc->modem_index] == NULL) { |
| 1019 | if (UEA_CHIP_VERSION(sc) == ADI930) | 1019 | if (UEA_CHIP_VERSION(sc) == ADI930) |