diff options
author | FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | 2007-06-01 05:56:21 -0400 |
---|---|---|
committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2007-06-18 20:48:43 -0400 |
commit | da9c0c770e775e655e3f77c96d91ee557b117adb (patch) | |
tree | dc6f58cc48e120182915249fcb62718e8abec46d | |
parent | 40fc79eb0223eccf44ed2e90fb11b9a08bcc7e09 (diff) |
[SCSI] iscsi_iser: convert to use the data buffer accessors
iscsi_iser: convert to use the data buffer accessors
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.
TODO: use scsi_for_each_sg().
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Erez Zilber <erezz@voltaire.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
-rw-r--r-- | drivers/infiniband/ulp/iser/iscsi_iser.c | 4 | ||||
-rw-r--r-- | drivers/infiniband/ulp/iser/iser_initiator.c | 14 |
2 files changed, 6 insertions, 12 deletions
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c index 1bf173decade..effdee299b0c 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.c +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c | |||
@@ -210,10 +210,10 @@ iscsi_iser_ctask_xmit(struct iscsi_conn *conn, | |||
210 | int error = 0; | 210 | int error = 0; |
211 | 211 | ||
212 | if (ctask->sc->sc_data_direction == DMA_TO_DEVICE) { | 212 | if (ctask->sc->sc_data_direction == DMA_TO_DEVICE) { |
213 | BUG_ON(ctask->sc->request_bufflen == 0); | 213 | BUG_ON(scsi_bufflen(ctask->sc) == 0); |
214 | 214 | ||
215 | debug_scsi("cmd [itt %x total %d imm %d unsol_data %d\n", | 215 | debug_scsi("cmd [itt %x total %d imm %d unsol_data %d\n", |
216 | ctask->itt, ctask->sc->request_bufflen, | 216 | ctask->itt, scsi_bufflen(ctask->sc), |
217 | ctask->imm_count, ctask->unsol_count); | 217 | ctask->imm_count, ctask->unsol_count); |
218 | } | 218 | } |
219 | 219 | ||
diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 3651072f6c1f..9ea5b9aaba7c 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c | |||
@@ -351,18 +351,12 @@ int iser_send_command(struct iscsi_conn *conn, | |||
351 | else | 351 | else |
352 | data_buf = &iser_ctask->data[ISER_DIR_OUT]; | 352 | data_buf = &iser_ctask->data[ISER_DIR_OUT]; |
353 | 353 | ||
354 | if (sc->use_sg) { /* using a scatter list */ | 354 | if (scsi_sg_count(sc)) { /* using a scatter list */ |
355 | data_buf->buf = sc->request_buffer; | 355 | data_buf->buf = scsi_sglist(sc); |
356 | data_buf->size = sc->use_sg; | 356 | data_buf->size = scsi_sg_count(sc); |
357 | } else if (sc->request_bufflen) { | ||
358 | /* using a single buffer - convert it into one entry SG */ | ||
359 | sg_init_one(&data_buf->sg_single, | ||
360 | sc->request_buffer, sc->request_bufflen); | ||
361 | data_buf->buf = &data_buf->sg_single; | ||
362 | data_buf->size = 1; | ||
363 | } | 357 | } |
364 | 358 | ||
365 | data_buf->data_len = sc->request_bufflen; | 359 | data_buf->data_len = scsi_bufflen(sc); |
366 | 360 | ||
367 | if (hdr->flags & ISCSI_FLAG_CMD_READ) { | 361 | if (hdr->flags & ISCSI_FLAG_CMD_READ) { |
368 | err = iser_prepare_read_cmd(ctask, edtl); | 362 | err = iser_prepare_read_cmd(ctask, edtl); |