diff options
author | Yoann Padioleau <padator@wanadoo.fr> | 2007-07-27 05:45:00 -0400 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2007-07-31 16:35:22 -0400 |
commit | 7e5829b56be5aeb931cf52d78c95285c2b8f50e3 (patch) | |
tree | bb189a9b13e26383ada7c50d7934d2d6126d8e61 | |
parent | 72db43be8bf610d50d86a9e683e0eff3c2cc5ba4 (diff) |
[MIPS] 0 -> NULL
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E ==
- 0
+ NULL
@@
expression *E;
@@
E !=
- 0
+ NULL
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Cc: akpm@linux-foundation.org
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
-rw-r--r-- | arch/mips/pci/ops-emma2rh.c | 2 | ||||
-rw-r--r-- | arch/mips/pci/ops-pnx8550.c | 12 |
2 files changed, 7 insertions, 7 deletions
diff --git a/arch/mips/pci/ops-emma2rh.c b/arch/mips/pci/ops-emma2rh.c index 38f181625e10..d31bfc6d4150 100644 --- a/arch/mips/pci/ops-emma2rh.c +++ b/arch/mips/pci/ops-emma2rh.c | |||
@@ -45,7 +45,7 @@ static int check_args(struct pci_bus *bus, u32 devfn, u32 * bus_num) | |||
45 | /* check if the bus is top-level */ | 45 | /* check if the bus is top-level */ |
46 | if (bus->parent != NULL) { | 46 | if (bus->parent != NULL) { |
47 | *bus_num = bus->number; | 47 | *bus_num = bus->number; |
48 | db_assert(bus_num != 0); | 48 | db_assert(bus_num != NULL); |
49 | } else | 49 | } else |
50 | *bus_num = 0; | 50 | *bus_num = 0; |
51 | 51 | ||
diff --git a/arch/mips/pci/ops-pnx8550.c b/arch/mips/pci/ops-pnx8550.c index f556b7a8dccd..d61064652498 100644 --- a/arch/mips/pci/ops-pnx8550.c +++ b/arch/mips/pci/ops-pnx8550.c | |||
@@ -117,7 +117,7 @@ read_config_byte(struct pci_bus *bus, unsigned int devfn, int where, u8 * val) | |||
117 | unsigned int data = 0; | 117 | unsigned int data = 0; |
118 | int err; | 118 | int err; |
119 | 119 | ||
120 | if (bus == 0) | 120 | if (bus == NULL) |
121 | return -1; | 121 | return -1; |
122 | 122 | ||
123 | err = config_access(PCI_CMD_CONFIG_READ, bus, devfn, where, ~(1 << (where & 3)), &data); | 123 | err = config_access(PCI_CMD_CONFIG_READ, bus, devfn, where, ~(1 << (where & 3)), &data); |
@@ -145,7 +145,7 @@ read_config_word(struct pci_bus *bus, unsigned int devfn, int where, u16 * val) | |||
145 | unsigned int data = 0; | 145 | unsigned int data = 0; |
146 | int err; | 146 | int err; |
147 | 147 | ||
148 | if (bus == 0) | 148 | if (bus == NULL) |
149 | return -1; | 149 | return -1; |
150 | 150 | ||
151 | if (where & 0x01) | 151 | if (where & 0x01) |
@@ -168,7 +168,7 @@ static int | |||
168 | read_config_dword(struct pci_bus *bus, unsigned int devfn, int where, u32 * val) | 168 | read_config_dword(struct pci_bus *bus, unsigned int devfn, int where, u32 * val) |
169 | { | 169 | { |
170 | int err; | 170 | int err; |
171 | if (bus == 0) | 171 | if (bus == NULL) |
172 | return -1; | 172 | return -1; |
173 | 173 | ||
174 | if (where & 0x03) | 174 | if (where & 0x03) |
@@ -185,7 +185,7 @@ write_config_byte(struct pci_bus *bus, unsigned int devfn, int where, u8 val) | |||
185 | unsigned int data = (unsigned int)val; | 185 | unsigned int data = (unsigned int)val; |
186 | int err; | 186 | int err; |
187 | 187 | ||
188 | if (bus == 0) | 188 | if (bus == NULL) |
189 | return -1; | 189 | return -1; |
190 | 190 | ||
191 | switch (where & 0x03) { | 191 | switch (where & 0x03) { |
@@ -213,7 +213,7 @@ write_config_word(struct pci_bus *bus, unsigned int devfn, int where, u16 val) | |||
213 | unsigned int data = (unsigned int)val; | 213 | unsigned int data = (unsigned int)val; |
214 | int err; | 214 | int err; |
215 | 215 | ||
216 | if (bus == 0) | 216 | if (bus == NULL) |
217 | return -1; | 217 | return -1; |
218 | 218 | ||
219 | if (where & 0x01) | 219 | if (where & 0x01) |
@@ -235,7 +235,7 @@ static int | |||
235 | write_config_dword(struct pci_bus *bus, unsigned int devfn, int where, u32 val) | 235 | write_config_dword(struct pci_bus *bus, unsigned int devfn, int where, u32 val) |
236 | { | 236 | { |
237 | int err; | 237 | int err; |
238 | if (bus == 0) | 238 | if (bus == NULL) |
239 | return -1; | 239 | return -1; |
240 | 240 | ||
241 | if (where & 0x03) | 241 | if (where & 0x03) |