diff options
author | Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> | 2007-10-16 18:38:25 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2007-10-17 18:50:02 -0400 |
commit | 5272f8372786a181313c00c7a67304ac6def2e34 (patch) | |
tree | d410591f49209a5a6ae4f04152fb91d1556c946a | |
parent | 3a14589cceea4c5d2d4de0369ee10b0fb627b107 (diff) |
ext4: Convert bg_inode_bitmap and bg_inode_table
Convert bg_inode_bitmap and bg_inode_table to bg_inode_bitmap_lo
and bg_inode_table_lo. This helps in finding BUGs due to
direct partial access of these split 64 bit values
Also fix one direct partial access
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
-rw-r--r-- | fs/ext4/balloc.c | 2 | ||||
-rw-r--r-- | fs/ext4/super.c | 12 | ||||
-rw-r--r-- | include/linux/ext4_fs.h | 4 |
3 files changed, 9 insertions, 9 deletions
diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c index 5927687b3e79..e906b65448e2 100644 --- a/fs/ext4/balloc.c +++ b/fs/ext4/balloc.c | |||
@@ -115,7 +115,7 @@ unsigned ext4_init_block_bitmap(struct super_block *sb, struct buffer_head *bh, | |||
115 | /* Set bits for block and inode bitmaps, and inode table */ | 115 | /* Set bits for block and inode bitmaps, and inode table */ |
116 | ext4_set_bit(ext4_block_bitmap(sb, gdp) - start, bh->b_data); | 116 | ext4_set_bit(ext4_block_bitmap(sb, gdp) - start, bh->b_data); |
117 | ext4_set_bit(ext4_inode_bitmap(sb, gdp) - start, bh->b_data); | 117 | ext4_set_bit(ext4_inode_bitmap(sb, gdp) - start, bh->b_data); |
118 | for (bit = le32_to_cpu(gdp->bg_inode_table) - start, | 118 | for (bit = (ext4_inode_table(sb, gdp) - start), |
119 | bit_max = bit + sbi->s_itb_per_group; bit < bit_max; bit++) | 119 | bit_max = bit + sbi->s_itb_per_group; bit < bit_max; bit++) |
120 | ext4_set_bit(bit, bh->b_data); | 120 | ext4_set_bit(bit, bh->b_data); |
121 | 121 | ||
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 1e8eaaf2d4a5..f9cb64c5010b 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
@@ -78,17 +78,17 @@ ext4_fsblk_t ext4_block_bitmap(struct super_block *sb, | |||
78 | ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb, | 78 | ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb, |
79 | struct ext4_group_desc *bg) | 79 | struct ext4_group_desc *bg) |
80 | { | 80 | { |
81 | return le32_to_cpu(bg->bg_inode_bitmap) | | 81 | return le32_to_cpu(bg->bg_inode_bitmap_lo) | |
82 | (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ? | 82 | (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ? |
83 | (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_bitmap_hi) << 32 : 0); | 83 | (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_bitmap_hi) << 32 : 0); |
84 | } | 84 | } |
85 | 85 | ||
86 | ext4_fsblk_t ext4_inode_table(struct super_block *sb, | 86 | ext4_fsblk_t ext4_inode_table(struct super_block *sb, |
87 | struct ext4_group_desc *bg) | 87 | struct ext4_group_desc *bg) |
88 | { | 88 | { |
89 | return le32_to_cpu(bg->bg_inode_table) | | 89 | return le32_to_cpu(bg->bg_inode_table_lo) | |
90 | (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ? | 90 | (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT ? |
91 | (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_table_hi) << 32 : 0); | 91 | (ext4_fsblk_t)le32_to_cpu(bg->bg_inode_table_hi) << 32 : 0); |
92 | } | 92 | } |
93 | 93 | ||
94 | void ext4_block_bitmap_set(struct super_block *sb, | 94 | void ext4_block_bitmap_set(struct super_block *sb, |
@@ -102,7 +102,7 @@ void ext4_block_bitmap_set(struct super_block *sb, | |||
102 | void ext4_inode_bitmap_set(struct super_block *sb, | 102 | void ext4_inode_bitmap_set(struct super_block *sb, |
103 | struct ext4_group_desc *bg, ext4_fsblk_t blk) | 103 | struct ext4_group_desc *bg, ext4_fsblk_t blk) |
104 | { | 104 | { |
105 | bg->bg_inode_bitmap = cpu_to_le32((u32)blk); | 105 | bg->bg_inode_bitmap_lo = cpu_to_le32((u32)blk); |
106 | if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT) | 106 | if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT) |
107 | bg->bg_inode_bitmap_hi = cpu_to_le32(blk >> 32); | 107 | bg->bg_inode_bitmap_hi = cpu_to_le32(blk >> 32); |
108 | } | 108 | } |
@@ -110,7 +110,7 @@ void ext4_inode_bitmap_set(struct super_block *sb, | |||
110 | void ext4_inode_table_set(struct super_block *sb, | 110 | void ext4_inode_table_set(struct super_block *sb, |
111 | struct ext4_group_desc *bg, ext4_fsblk_t blk) | 111 | struct ext4_group_desc *bg, ext4_fsblk_t blk) |
112 | { | 112 | { |
113 | bg->bg_inode_table = cpu_to_le32((u32)blk); | 113 | bg->bg_inode_table_lo = cpu_to_le32((u32)blk); |
114 | if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT) | 114 | if (EXT4_DESC_SIZE(sb) >= EXT4_MIN_DESC_SIZE_64BIT) |
115 | bg->bg_inode_table_hi = cpu_to_le32(blk >> 32); | 115 | bg->bg_inode_table_hi = cpu_to_le32(blk >> 32); |
116 | } | 116 | } |
diff --git a/include/linux/ext4_fs.h b/include/linux/ext4_fs.h index 1dab9847a206..f5d57c7c0dd7 100644 --- a/include/linux/ext4_fs.h +++ b/include/linux/ext4_fs.h | |||
@@ -106,8 +106,8 @@ | |||
106 | struct ext4_group_desc | 106 | struct ext4_group_desc |
107 | { | 107 | { |
108 | __le32 bg_block_bitmap_lo; /* Blocks bitmap block */ | 108 | __le32 bg_block_bitmap_lo; /* Blocks bitmap block */ |
109 | __le32 bg_inode_bitmap; /* Inodes bitmap block */ | 109 | __le32 bg_inode_bitmap_lo; /* Inodes bitmap block */ |
110 | __le32 bg_inode_table; /* Inodes table block */ | 110 | __le32 bg_inode_table_lo; /* Inodes table block */ |
111 | __le16 bg_free_blocks_count; /* Free blocks count */ | 111 | __le16 bg_free_blocks_count; /* Free blocks count */ |
112 | __le16 bg_free_inodes_count; /* Free inodes count */ | 112 | __le16 bg_free_inodes_count; /* Free inodes count */ |
113 | __le16 bg_used_dirs_count; /* Directories count */ | 113 | __le16 bg_used_dirs_count; /* Directories count */ |