diff options
author | Nishanth Aravamudan <nacc@us.ibm.com> | 2005-08-15 14:30:11 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2005-09-12 15:23:44 -0400 |
commit | 22c438632850c0d6257b45c90afed0cea6953afc (patch) | |
tree | eb70da121b1fab2a2626167575aa38ed3013fc65 | |
parent | dd16525b698528172899f10c14a3eb6ddb888a53 (diff) |
[PATCH] drivers/usb: fix-up schedule_timeout() usage
Description: Use schedule_timeout_{,un}interruptible() instead of
set_current_state()/schedule_timeout() to reduce kernel size.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/usb/class/audio.c | 12 | ||||
-rw-r--r-- | drivers/usb/host/ehci-hcd.c | 3 | ||||
-rw-r--r-- | drivers/usb/host/ohci-hcd.c | 3 | ||||
-rw-r--r-- | drivers/usb/serial/cypress_m8.c | 3 | ||||
-rw-r--r-- | drivers/usb/serial/pl2303.c | 3 |
5 files changed, 12 insertions, 12 deletions
diff --git a/drivers/usb/class/audio.c b/drivers/usb/class/audio.c index f8f21567cc22..50858273f8d3 100644 --- a/drivers/usb/class/audio.c +++ b/drivers/usb/class/audio.c | |||
@@ -631,8 +631,10 @@ static void usbin_stop(struct usb_audiodev *as) | |||
631 | i = u->flags; | 631 | i = u->flags; |
632 | spin_unlock_irqrestore(&as->lock, flags); | 632 | spin_unlock_irqrestore(&as->lock, flags); |
633 | while (i & (FLG_URB0RUNNING|FLG_URB1RUNNING|FLG_SYNC0RUNNING|FLG_SYNC1RUNNING)) { | 633 | while (i & (FLG_URB0RUNNING|FLG_URB1RUNNING|FLG_SYNC0RUNNING|FLG_SYNC1RUNNING)) { |
634 | set_current_state(notkilled ? TASK_INTERRUPTIBLE : TASK_UNINTERRUPTIBLE); | 634 | if (notkilled) |
635 | schedule_timeout(1); | 635 | schedule_timeout_interruptible(1); |
636 | else | ||
637 | schedule_timeout_uninterruptible(1); | ||
636 | spin_lock_irqsave(&as->lock, flags); | 638 | spin_lock_irqsave(&as->lock, flags); |
637 | i = u->flags; | 639 | i = u->flags; |
638 | spin_unlock_irqrestore(&as->lock, flags); | 640 | spin_unlock_irqrestore(&as->lock, flags); |
@@ -1102,8 +1104,10 @@ static void usbout_stop(struct usb_audiodev *as) | |||
1102 | i = u->flags; | 1104 | i = u->flags; |
1103 | spin_unlock_irqrestore(&as->lock, flags); | 1105 | spin_unlock_irqrestore(&as->lock, flags); |
1104 | while (i & (FLG_URB0RUNNING|FLG_URB1RUNNING|FLG_SYNC0RUNNING|FLG_SYNC1RUNNING)) { | 1106 | while (i & (FLG_URB0RUNNING|FLG_URB1RUNNING|FLG_SYNC0RUNNING|FLG_SYNC1RUNNING)) { |
1105 | set_current_state(notkilled ? TASK_INTERRUPTIBLE : TASK_UNINTERRUPTIBLE); | 1107 | if (notkilled) |
1106 | schedule_timeout(1); | 1108 | schedule_timeout_interruptible(1); |
1109 | else | ||
1110 | schedule_timeout_uninterruptible(1); | ||
1107 | spin_lock_irqsave(&as->lock, flags); | 1111 | spin_lock_irqsave(&as->lock, flags); |
1108 | i = u->flags; | 1112 | i = u->flags; |
1109 | spin_unlock_irqrestore(&as->lock, flags); | 1113 | spin_unlock_irqrestore(&as->lock, flags); |
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index ae5ba4ddfb40..b948ffd94f45 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c | |||
@@ -1147,8 +1147,7 @@ rescan: | |||
1147 | case QH_STATE_UNLINK: /* wait for hw to finish? */ | 1147 | case QH_STATE_UNLINK: /* wait for hw to finish? */ |
1148 | idle_timeout: | 1148 | idle_timeout: |
1149 | spin_unlock_irqrestore (&ehci->lock, flags); | 1149 | spin_unlock_irqrestore (&ehci->lock, flags); |
1150 | set_current_state (TASK_UNINTERRUPTIBLE); | 1150 | schedule_timeout_uninterruptible(1); |
1151 | schedule_timeout (1); | ||
1152 | goto rescan; | 1151 | goto rescan; |
1153 | case QH_STATE_IDLE: /* fully unlinked */ | 1152 | case QH_STATE_IDLE: /* fully unlinked */ |
1154 | if (list_empty (&qh->qtd_list)) { | 1153 | if (list_empty (&qh->qtd_list)) { |
diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 56b43f2a0e52..ddaa9c82c58d 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c | |||
@@ -382,8 +382,7 @@ sanitize: | |||
382 | goto sanitize; | 382 | goto sanitize; |
383 | } | 383 | } |
384 | spin_unlock_irqrestore (&ohci->lock, flags); | 384 | spin_unlock_irqrestore (&ohci->lock, flags); |
385 | set_current_state (TASK_UNINTERRUPTIBLE); | 385 | schedule_timeout_uninterruptible(1); |
386 | schedule_timeout (1); | ||
387 | goto rescan; | 386 | goto rescan; |
388 | case ED_IDLE: /* fully unlinked */ | 387 | case ED_IDLE: /* fully unlinked */ |
389 | if (list_empty (&ed->td_list)) { | 388 | if (list_empty (&ed->td_list)) { |
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c index 05c44ae3ed32..9ee1aaff2fcd 100644 --- a/drivers/usb/serial/cypress_m8.c +++ b/drivers/usb/serial/cypress_m8.c | |||
@@ -610,8 +610,7 @@ static void cypress_close(struct usb_serial_port *port, struct file * filp) | |||
610 | timeout = max((HZ*2560)/bps,HZ/10); | 610 | timeout = max((HZ*2560)/bps,HZ/10); |
611 | else | 611 | else |
612 | timeout = 2*HZ; | 612 | timeout = 2*HZ; |
613 | set_current_state(TASK_INTERRUPTIBLE); | 613 | schedule_timeout_interruptible(timeout); |
614 | schedule_timeout(timeout); | ||
615 | 614 | ||
616 | dbg("%s - stopping urbs", __FUNCTION__); | 615 | dbg("%s - stopping urbs", __FUNCTION__); |
617 | usb_kill_urb (port->interrupt_in_urb); | 616 | usb_kill_urb (port->interrupt_in_urb); |
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 461474176cfb..ea8c6e74be4f 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c | |||
@@ -652,8 +652,7 @@ static void pl2303_close (struct usb_serial_port *port, struct file *filp) | |||
652 | timeout = max((HZ*2560)/bps,HZ/10); | 652 | timeout = max((HZ*2560)/bps,HZ/10); |
653 | else | 653 | else |
654 | timeout = 2*HZ; | 654 | timeout = 2*HZ; |
655 | set_current_state(TASK_INTERRUPTIBLE); | 655 | schedule_timeout_interruptible(timeout); |
656 | schedule_timeout(timeout); | ||
657 | 656 | ||
658 | /* shutdown our urbs */ | 657 | /* shutdown our urbs */ |
659 | dbg("%s - shutting down urbs", __FUNCTION__); | 658 | dbg("%s - shutting down urbs", __FUNCTION__); |