diff options
author | Tejun Heo <htejun@gmail.com> | 2006-09-30 06:45:00 -0400 |
---|---|---|
committer | Jeff Garzik <jeff@garzik.org> | 2006-09-30 07:39:24 -0400 |
commit | 360f654e7cda850034f3f6252a7a7cff3fa77356 (patch) | |
tree | 2279e397c59501cfda60d7d97d4976e42b8f2983 | |
parent | e5c9e081e9c980fa785cd9002c25a251cf3f090e (diff) |
[PATCH] libata: turn off NCQ if queue depth is adjusted to 1
Turn off NCQ if queue depth is adjusted to 1.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
-rw-r--r-- | drivers/ata/libata-scsi.c | 12 | ||||
-rw-r--r-- | include/linux/libata.h | 1 |
2 files changed, 12 insertions, 1 deletions
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index b4a0246506ef..b0d0cc41f3e8 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c | |||
@@ -889,6 +889,7 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth) | |||
889 | { | 889 | { |
890 | struct ata_port *ap = ata_shost_to_port(sdev->host); | 890 | struct ata_port *ap = ata_shost_to_port(sdev->host); |
891 | struct ata_device *dev; | 891 | struct ata_device *dev; |
892 | unsigned long flags; | ||
892 | int max_depth; | 893 | int max_depth; |
893 | 894 | ||
894 | if (queue_depth < 1) | 895 | if (queue_depth < 1) |
@@ -904,6 +905,14 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth) | |||
904 | queue_depth = max_depth; | 905 | queue_depth = max_depth; |
905 | 906 | ||
906 | scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, queue_depth); | 907 | scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, queue_depth); |
908 | |||
909 | spin_lock_irqsave(ap->lock, flags); | ||
910 | if (queue_depth > 1) | ||
911 | dev->flags &= ~ATA_DFLAG_NCQ_OFF; | ||
912 | else | ||
913 | dev->flags |= ATA_DFLAG_NCQ_OFF; | ||
914 | spin_unlock_irqrestore(ap->lock, flags); | ||
915 | |||
907 | return queue_depth; | 916 | return queue_depth; |
908 | } | 917 | } |
909 | 918 | ||
@@ -1293,7 +1302,8 @@ static unsigned int ata_scsi_rw_xlat(struct ata_queued_cmd *qc, const u8 *scsicm | |||
1293 | */ | 1302 | */ |
1294 | goto nothing_to_do; | 1303 | goto nothing_to_do; |
1295 | 1304 | ||
1296 | if ((dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ) { | 1305 | if ((dev->flags & (ATA_DFLAG_PIO | ATA_DFLAG_NCQ_OFF | |
1306 | ATA_DFLAG_NCQ)) == ATA_DFLAG_NCQ) { | ||
1297 | /* yay, NCQ */ | 1307 | /* yay, NCQ */ |
1298 | if (!lba_48_ok(block, n_block)) | 1308 | if (!lba_48_ok(block, n_block)) |
1299 | goto out_of_range; | 1309 | goto out_of_range; |
diff --git a/include/linux/libata.h b/include/linux/libata.h index e54a5fd6a41e..d1af1dbeaeb4 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h | |||
@@ -143,6 +143,7 @@ enum { | |||
143 | ATA_DFLAG_CFG_MASK = (1 << 8) - 1, | 143 | ATA_DFLAG_CFG_MASK = (1 << 8) - 1, |
144 | 144 | ||
145 | ATA_DFLAG_PIO = (1 << 8), /* device limited to PIO mode */ | 145 | ATA_DFLAG_PIO = (1 << 8), /* device limited to PIO mode */ |
146 | ATA_DFLAG_NCQ_OFF = (1 << 9), /* devied limited to non-NCQ mode */ | ||
146 | ATA_DFLAG_SUSPENDED = (1 << 10), /* device suspended */ | 147 | ATA_DFLAG_SUSPENDED = (1 << 10), /* device suspended */ |
147 | ATA_DFLAG_INIT_MASK = (1 << 16) - 1, | 148 | ATA_DFLAG_INIT_MASK = (1 << 16) - 1, |
148 | 149 | ||