diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2005-06-22 13:16:31 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2005-06-22 16:07:40 -0400 |
commit | 80fec4c62e2cf544ac26e53f3e0d2f73df6820b9 (patch) | |
tree | 00baef91b0025dba29b26fc83aa243ed7c52ed1c | |
parent | 3da28eb1c6545fe73263a24eba0996217490e1eb (diff) |
[PATCH] VFS: Ensure that all the on-stack struct file_lock call fl_release_private
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | fs/locks.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/locks.c b/fs/locks.c index 3fa6a7ce57a7..a0bc03495bd4 100644 --- a/fs/locks.c +++ b/fs/locks.c | |||
@@ -1548,6 +1548,8 @@ int fcntl_getlk(struct file *filp, struct flock __user *l) | |||
1548 | 1548 | ||
1549 | if (filp->f_op && filp->f_op->lock) { | 1549 | if (filp->f_op && filp->f_op->lock) { |
1550 | error = filp->f_op->lock(filp, F_GETLK, &file_lock); | 1550 | error = filp->f_op->lock(filp, F_GETLK, &file_lock); |
1551 | if (file_lock.fl_ops && file_lock.fl_ops->fl_release_private) | ||
1552 | file_lock.fl_ops->fl_release_private(&file_lock); | ||
1551 | if (error < 0) | 1553 | if (error < 0) |
1552 | goto out; | 1554 | goto out; |
1553 | else | 1555 | else |
@@ -1690,6 +1692,8 @@ int fcntl_getlk64(struct file *filp, struct flock64 __user *l) | |||
1690 | 1692 | ||
1691 | if (filp->f_op && filp->f_op->lock) { | 1693 | if (filp->f_op && filp->f_op->lock) { |
1692 | error = filp->f_op->lock(filp, F_GETLK, &file_lock); | 1694 | error = filp->f_op->lock(filp, F_GETLK, &file_lock); |
1695 | if (file_lock.fl_ops && file_lock.fl_ops->fl_release_private) | ||
1696 | file_lock.fl_ops->fl_release_private(&file_lock); | ||
1693 | if (error < 0) | 1697 | if (error < 0) |
1694 | goto out; | 1698 | goto out; |
1695 | else | 1699 | else |
@@ -1873,6 +1877,8 @@ void locks_remove_flock(struct file *filp) | |||
1873 | .fl_end = OFFSET_MAX, | 1877 | .fl_end = OFFSET_MAX, |
1874 | }; | 1878 | }; |
1875 | filp->f_op->flock(filp, F_SETLKW, &fl); | 1879 | filp->f_op->flock(filp, F_SETLKW, &fl); |
1880 | if (fl.fl_ops && fl.fl_ops->fl_release_private) | ||
1881 | fl.fl_ops->fl_release_private(&fl); | ||
1876 | } | 1882 | } |
1877 | 1883 | ||
1878 | lock_kernel(); | 1884 | lock_kernel(); |