diff options
author | Michal Ludvig <michal@logix.cz> | 2006-07-14 21:08:50 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2006-07-14 21:08:50 -0400 |
commit | cc08632f8f26d479500f8107c84e206770cb901c (patch) | |
tree | bd1cdf141a816571dda1ffcea130875f66e48e63 | |
parent | ab6cf0d0cb96417ef65cc2c2120c0e879edf7a4a (diff) |
[CRYPTO] padlock: Fix alignment after aes_ctx rearrange
Herbert's patch 82062c72cd643c99a9e1c231270acbab986fd23f
in cryptodev-2.6 tree breaks alignment rules for PadLock
xcrypt instruction leading to General protection Oopses.
This patch fixes the problem.
Signed-off-by: Michal Ludvig <michal@logix.cz>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r-- | drivers/crypto/padlock-aes.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/drivers/crypto/padlock-aes.c b/drivers/crypto/padlock-aes.c index 17ee684144f9..b643d71298a9 100644 --- a/drivers/crypto/padlock-aes.c +++ b/drivers/crypto/padlock-aes.c | |||
@@ -59,6 +59,9 @@ | |||
59 | #define AES_EXTENDED_KEY_SIZE 64 /* in uint32_t units */ | 59 | #define AES_EXTENDED_KEY_SIZE 64 /* in uint32_t units */ |
60 | #define AES_EXTENDED_KEY_SIZE_B (AES_EXTENDED_KEY_SIZE * sizeof(uint32_t)) | 60 | #define AES_EXTENDED_KEY_SIZE_B (AES_EXTENDED_KEY_SIZE * sizeof(uint32_t)) |
61 | 61 | ||
62 | /* Whenever making any changes to the following | ||
63 | * structure *make sure* you keep E, d_data | ||
64 | * and cword aligned on 16 Bytes boundaries!!! */ | ||
62 | struct aes_ctx { | 65 | struct aes_ctx { |
63 | struct { | 66 | struct { |
64 | struct cword encrypt; | 67 | struct cword encrypt; |
@@ -66,8 +69,10 @@ struct aes_ctx { | |||
66 | } cword; | 69 | } cword; |
67 | u32 *D; | 70 | u32 *D; |
68 | int key_length; | 71 | int key_length; |
69 | u32 E[AES_EXTENDED_KEY_SIZE]; | 72 | u32 E[AES_EXTENDED_KEY_SIZE] |
70 | u32 d_data[AES_EXTENDED_KEY_SIZE]; | 73 | __attribute__ ((__aligned__(PADLOCK_ALIGNMENT))); |
74 | u32 d_data[AES_EXTENDED_KEY_SIZE] | ||
75 | __attribute__ ((__aligned__(PADLOCK_ALIGNMENT))); | ||
71 | }; | 76 | }; |
72 | 77 | ||
73 | /* ====== Key management routines ====== */ | 78 | /* ====== Key management routines ====== */ |