aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTing Yang <tingy@cs.umass.edu>2007-08-28 06:53:24 -0400
committerIngo Molnar <mingo@elte.hu>2007-08-28 06:53:24 -0400
commit7109c4429af3640f79a638f177fc5d05b9807149 (patch)
tree8ea42387ba3fe5d9bc966e3b488699f4f8af322f
parentf6cf891c4d7128f9f91243fc0b9ce99e10fa1586 (diff)
sched: call update_curr() in task_tick_fair()
update the fair-clock before using it for the key value. [ mingo@elte.hu: small cleanups. ] Signed-off-by: Ting Yang <tingy@cs.umass.edu> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Mike Galbraith <efault@gmx.de> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
-rw-r--r--kernel/sched_fair.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
index 721fe7744874..9f06094e5275 100644
--- a/kernel/sched_fair.c
+++ b/kernel/sched_fair.c
@@ -1094,10 +1094,11 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr)
1094static void task_new_fair(struct rq *rq, struct task_struct *p) 1094static void task_new_fair(struct rq *rq, struct task_struct *p)
1095{ 1095{
1096 struct cfs_rq *cfs_rq = task_cfs_rq(p); 1096 struct cfs_rq *cfs_rq = task_cfs_rq(p);
1097 struct sched_entity *se = &p->se; 1097 struct sched_entity *se = &p->se, *curr = cfs_rq_curr(cfs_rq);
1098 1098
1099 sched_info_queued(p); 1099 sched_info_queued(p);
1100 1100
1101 update_curr(cfs_rq);
1101 update_stats_enqueue(cfs_rq, se); 1102 update_stats_enqueue(cfs_rq, se);
1102 /* 1103 /*
1103 * Child runs first: we let it run before the parent 1104 * Child runs first: we let it run before the parent
@@ -1105,7 +1106,7 @@ static void task_new_fair(struct rq *rq, struct task_struct *p)
1105 * it will preempt the parent: 1106 * it will preempt the parent:
1106 */ 1107 */
1107 p->se.fair_key = current->se.fair_key - 1108 p->se.fair_key = current->se.fair_key -
1108 niced_granularity(&rq->curr->se, sched_granularity(cfs_rq)) - 1; 1109 niced_granularity(curr, sched_granularity(cfs_rq)) - 1;
1109 /* 1110 /*
1110 * The first wait is dominated by the child-runs-first logic, 1111 * The first wait is dominated by the child-runs-first logic,
1111 * so do not credit it with that waiting time yet: 1112 * so do not credit it with that waiting time yet: