diff options
author | Sripathi Kodi <sripathik@in.ibm.com> | 2007-07-16 02:39:26 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-16 12:05:40 -0400 |
commit | 6175ecfed3c81d388735c75f7a0ad08dc4de02d3 (patch) | |
tree | 83ac354507db40109bd114c233de2e7c36c92231 | |
parent | e1f4a88c5a15a86124a95ea712213bb7dab2ad99 (diff) |
Use write_trylock_irqsave in ptrace_attach
This patch makes ptrace_attach use write_trylock_irqsave().
[akpm@linux-foundation.org: remove unneeded initialisation]
Signed-off-by: Sripathi Kodi <sripathik@in.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | kernel/ptrace.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/kernel/ptrace.c b/kernel/ptrace.c index ad7949a589dd..b1d11f1c7cf7 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c | |||
@@ -161,6 +161,7 @@ int ptrace_may_attach(struct task_struct *task) | |||
161 | int ptrace_attach(struct task_struct *task) | 161 | int ptrace_attach(struct task_struct *task) |
162 | { | 162 | { |
163 | int retval; | 163 | int retval; |
164 | unsigned long flags; | ||
164 | 165 | ||
165 | audit_ptrace(task); | 166 | audit_ptrace(task); |
166 | 167 | ||
@@ -181,9 +182,7 @@ repeat: | |||
181 | * cpu's that may have task_lock). | 182 | * cpu's that may have task_lock). |
182 | */ | 183 | */ |
183 | task_lock(task); | 184 | task_lock(task); |
184 | local_irq_disable(); | 185 | if (!write_trylock_irqsave(&tasklist_lock, flags)) { |
185 | if (!write_trylock(&tasklist_lock)) { | ||
186 | local_irq_enable(); | ||
187 | task_unlock(task); | 186 | task_unlock(task); |
188 | do { | 187 | do { |
189 | cpu_relax(); | 188 | cpu_relax(); |
@@ -211,7 +210,7 @@ repeat: | |||
211 | force_sig_specific(SIGSTOP, task); | 210 | force_sig_specific(SIGSTOP, task); |
212 | 211 | ||
213 | bad: | 212 | bad: |
214 | write_unlock_irq(&tasklist_lock); | 213 | write_unlock_irqrestore(&tasklist_lock, flags); |
215 | task_unlock(task); | 214 | task_unlock(task); |
216 | out: | 215 | out: |
217 | return retval; | 216 | return retval; |