diff options
author | Dan Brown <dan_brown@ieee.org> | 2005-04-07 10:22:58 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@mtd.linutronix.de> | 2005-05-23 07:11:44 -0400 |
commit | abc37e6771ec92bb4c531d218ad572afbef6aa21 (patch) | |
tree | cc30e91741b76c94380748d5c6c0cb82d31a7e3f | |
parent | 7e4a1d3e6abec5464169a29a3d34473a59e2e8b7 (diff) |
[MTD] DiskOnChip: Add some comments
Add helpful comment about oobfree so I can't claim two years from
now that I don't remember what I was thinking.
Signed-off-by: Dan Brown <dan_brown@ieee.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | drivers/mtd/nand/diskonchip.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/drivers/mtd/nand/diskonchip.c b/drivers/mtd/nand/diskonchip.c index 9f33f335a39d..fdb5d4ad3d52 100644 --- a/drivers/mtd/nand/diskonchip.c +++ b/drivers/mtd/nand/diskonchip.c | |||
@@ -16,7 +16,7 @@ | |||
16 | * | 16 | * |
17 | * Interface to generic NAND code for M-Systems DiskOnChip devices | 17 | * Interface to generic NAND code for M-Systems DiskOnChip devices |
18 | * | 18 | * |
19 | * $Id: diskonchip.c,v 1.53 2005/04/07 13:39:13 dbrown Exp $ | 19 | * $Id: diskonchip.c,v 1.54 2005/04/07 14:22:55 dbrown Exp $ |
20 | */ | 20 | */ |
21 | 21 | ||
22 | #include <linux/kernel.h> | 22 | #include <linux/kernel.h> |
@@ -1049,6 +1049,16 @@ static int doc200x_correct_data(struct mtd_info *mtd, u_char *dat, u_char *read_ | |||
1049 | 1049 | ||
1050 | //u_char mydatabuf[528]; | 1050 | //u_char mydatabuf[528]; |
1051 | 1051 | ||
1052 | /* The strange out-of-order .oobfree list below is a (possibly unneeded) | ||
1053 | * attempt to retain compatibility. It used to read: | ||
1054 | * .oobfree = { {8, 8} } | ||
1055 | * Since that leaves two bytes unusable, it was changed. But the following | ||
1056 | * scheme might affect existing jffs2 installs by moving the cleanmarker: | ||
1057 | * .oobfree = { {6, 10} } | ||
1058 | * jffs2 seems to handle the above gracefully, but the current scheme seems | ||
1059 | * safer. The only problem with it is that any code that parses oobfree must | ||
1060 | * be able to handle out-of-order segments. | ||
1061 | */ | ||
1052 | static struct nand_oobinfo doc200x_oobinfo = { | 1062 | static struct nand_oobinfo doc200x_oobinfo = { |
1053 | .useecc = MTD_NANDECC_AUTOPLACE, | 1063 | .useecc = MTD_NANDECC_AUTOPLACE, |
1054 | .eccbytes = 6, | 1064 | .eccbytes = 6, |