aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2007-03-25 01:13:25 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-03-25 21:48:12 -0400
commit035832a2806408ff209a0cb94bd64ea7dcf4d222 (patch)
treee8c545d1689dc655690d981d4be113c3ae26b8bc
parentd3fa76ee6b4a8dd0efda4e78e96f5b19533b3dea (diff)
[NET_SCHED]: Fix ingress locking
Ingress queueing uses a seperate lock for serializing enqueue operations, but fails to properly protect itself against concurrent changes to the qdisc tree. Use queue_lock for now since the real fix it quite intrusive. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/dev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index cf71614dae93..5984b55311a1 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1750,10 +1750,10 @@ static int ing_filter(struct sk_buff *skb)
1750 1750
1751 skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_INGRESS); 1751 skb->tc_verd = SET_TC_AT(skb->tc_verd,AT_INGRESS);
1752 1752
1753 spin_lock(&dev->ingress_lock); 1753 spin_lock(&dev->queue_lock);
1754 if ((q = dev->qdisc_ingress) != NULL) 1754 if ((q = dev->qdisc_ingress) != NULL)
1755 result = q->enqueue(skb, q); 1755 result = q->enqueue(skb, q);
1756 spin_unlock(&dev->ingress_lock); 1756 spin_unlock(&dev->queue_lock);
1757 1757
1758 } 1758 }
1759 1759