aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndy Whitcroft <apw@shadowen.org>2008-10-16 01:02:19 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2008-10-16 14:21:35 -0400
commit01fa91471e9559d72c0c93ea7cca6f9fe6c2d1c3 (patch)
treed019ae001cd1ec82eff617388dce2d0ce9ac3159
parent636d140a80912693be466e8d978e658189972989 (diff)
checkpatch: fix up comment checks search to scan the entire block
We are not counting the lines in the block correctly which causes the comment scan to stop prematurly and thus miss comments which end at the end of the block. Fix this up. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rwxr-xr-xscripts/checkpatch.pl11
1 files changed, 8 insertions, 3 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 586f9a4f0ad0..482768cd5790 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1029,9 +1029,14 @@ sub process {
1029 # edge is a close comment then we must be in a comment 1029 # edge is a close comment then we must be in a comment
1030 # at context start. 1030 # at context start.
1031 my $edge; 1031 my $edge;
1032 for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) { 1032 my $cnt = $realcnt;
1033 next if ($line =~ /^-/); 1033 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1034 ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@); 1034 next if (defined $rawlines[$ln - 1] &&
1035 $rawlines[$ln - 1] =~ /^-/);
1036 $cnt--;
1037 #print "RAW<$rawlines[$ln - 1]>\n";
1038 ($edge) = (defined $rawlines[$ln - 1] &&
1039 $rawlines[$ln - 1] =~ m@(/\*|\*/)@);
1035 last if (defined $edge); 1040 last if (defined $edge);
1036 } 1041 }
1037 if (defined $edge && $edge eq '*/') { 1042 if (defined $edge && $edge eq '*/') {