cypress_m8: use usb_fill_int_urb where appropriate

Rather than directly filling in URB fields, it's safer to use
usb_fill_int_urb().  This improves robustness of the driver; URB
changes in the future will not go uninitialized here.  That point not
withstanding, this driver should at least be self-consistent.  Either
use usb_fill_int_urb() everywhere or don't bother with it all.

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 4 insertions, 3 deletions

diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 40cfbe1d3517..741dcec36d41 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -820,9 +820,10 @@ send:
         usb_serial_debug_data(debug, &port->dev, __FUNCTION__, port->interrupt_out_size,
                               port->interrupt_out_urb->transfer_buffer);
 
-        port->interrupt_out_urb->transfer_buffer_length = actual_size;
-        port->interrupt_out_urb->dev = port->serial->dev;
-        port->interrupt_out_urb->interval = priv->write_urb_interval;
+        usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev,
+                usb_sndintpipe(port->serial->dev, port->interrupt_out_endpointAddress),
+                port->interrupt_out_buffer, port->interrupt_out_size,
+                cypress_write_int_callback, port, priv->write_urb_interval);
         result = usb_submit_urb (port->interrupt_out_urb, GFP_ATOMIC);
         if (result) {
                 dev_err(&port->dev, "%s - failed submitting write urb, error %d\n", __FUNCTION__,